Bug 846362

Summary: [jboss-as5] Shutdown max wait time "shared" between different resources
Product: [JBoss] JBoss Operations Network Reporter: Lukas Krejci <lkrejci>
Component: Plugin -- JBoss EAP 5Assignee: Thomas Segismont <tsegismo>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: low    
Version: JON 3.1.0CC: fbrychta, hrupp, loleary
Target Milestone: ER01   
Target Release: JON 3.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 879065 879066 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 879065, 879066    
Bug Blocks:    
Attachments:
Description Flags
proposed patch none

Description Lukas Krejci 2012-08-07 14:49:18 UTC
Created attachment 602782 [details]
proposed patch

Description of problem:
This is a concurrency issue.

The problem is that while a shutdown operation on some AS5 resource is in progress, executing the shutdown operation on another AS5 resource on the same agent will override the max wait time of the two operations to the same value defined by the latter resource.

Version-Release number of selected component (if applicable):
4.5.0-SNAPSHOT

How reproducible:
always

Steps to Reproduce:
1. have 2 AS5 resources in inventory, make sure their shutdown takes more than 1 minute (not sure how to do this actually - possibly install a custom MBean that implements MBeanRegistration interface and sleep in preDeregister()?)
2. set the max wait time of 1 to 15 minutes, and 1minute on the other (2).
3. run shutdown on 1.
4. immediatelly run shutdown on 2
  
Actual results:
The operation on the server 1 times out after 1 minute

Expected results:
The operation on the server 1 should only timeout after 15 minutes or complete normally.

Additional info:

Comment 1 mark yarborough 2012-11-20 20:45:46 UTC
Per triage with loleary, crouch, mfoley: Move to JBoss ON product, set target release JON 3.2, clear priority (will be subject to further triage in JON 3.2 timeframe).

Comment 2 Heiko W. Rupp 2013-08-09 16:08:38 UTC
Thomas, if there is time left, could you look into this?

Comment 3 Thomas Segismont 2013-08-14 14:53:12 UTC
Fixed in master

commit 2a21d7b3a9a97248df2ab6d9d83804663c55972b
Author: Thomas Segismont <tsegismo>
Date:   Wed Aug 14 16:51:00 2013 +0200

Comment 4 Filip Brychta 2013-12-09 10:50:58 UTC
Verified on
Version :	
3.2.0.CR1
Build Number :	
6ecd678:d0dc0b6