Bug 847643 (libmateweather)
| Summary: | Review Request: libmateweather - Libraries to allow MATE Desktop to display weather information | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Mashal <dan.mashal> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-09-17 17:26:13 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 840149 | ||
|
Description
Dan Mashal
2012-08-13 08:20:26 UTC
You don't own %{_datadir}/icons/mate/ (mate-icon-theme owns it)
%files -f %{name}.lang
%doc AUTHORS COPYING README
%config(noreplace) %{_sysconfdir}/mateconf/schemas/mateweather.schemas
%{_datadir}/libmateweather/
%{_datadir}/icons/mate/
%{_datadir}/gtk-doc/html/libmateweather/
Thanks, Leigh. Will fix that shortly. Fixed. Spec URL: http://vicodan.fedorapeople.org/matespec/libmateweather.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/libmateweather-1.4.0-2.fc17.src.rpm This package has a mateconf schema.
%{_sysconfdir}/mateconf/schemas/mateweather.schemas
You've to add this in scriplet section. see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf
Note, the package from my repo use old scriplet style, so updating for f16/f17 will fail. See my comment in mate-notification-daemon.
You're right. Will fix. (In reply to comment #5) > You're right. Will fix. Move this to -devel where it belongs %{_libdir}/libmateweather.so and this can be removed from the -devel requires Requires: %{name}%{?_isa} = %{version}-%{release} as the -libs package already requires it Some initial comments:
1. SHOULD drop -libs subpkg, it's already named lib*, and it's contents have little/no chance to induce multilib conflicts
2. MUST move
%{python_sitearch}/mateweather/
to main pkg, fairly certain these are for runtime use (not -devel purposes)
3. per comment #4, MUST add mateconf schema scriptlets
Fixed. Spec URL: http://vicodan.fedorapeople.org/matespec/libmateweather.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/libmateweather-1.4.0-3.fc17.src.rpm Description: Libraries to allow MATE Desktop to display weather information The schema scriptlets look wrong, this is what I see in mate-vfs for example, %pre %mateconf_schema_prepare ... %preun %mateconf_schema_remove ... %post %mateconf_schema_upgrade ... Fixed. Fixed. Spec URL: http://vicodan.fedorapeople.org/matespec/libmateweather.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/libmateweather-1.4.0-4.fc17.src.rpm Description: Libraries to allow MATE Desktop to display weather information Good thanks, APPROVED. New Package SCM Request ======================= Package Name: libmateweather Short Description: Libraries to allow MATE Desktop to display weather information Owners: vicodan rdieter Branches: f16 f17 f18 Git done (by process-git-requests). libmateweather-1.4.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libmateweather-1.4.0-4.fc18 libmateweather-1.4.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libmateweather-1.4.0-4.fc17 libmateweather-1.4.0-5.fc18 has been pushed to the Fedora 18 testing repository. libmateweather-1.4.0-5.fc17 has been pushed to the Fedora 17 stable repository. libmateweather-1.4.0-5.fc18 has been pushed to the Fedora 18 stable repository. |