Bug 847643 (libmateweather) - Review Request: libmateweather - Libraries to allow MATE Desktop to display weather information
Summary: Review Request: libmateweather - Libraries to allow MATE Desktop to display w...
Status: CLOSED ERRATA
Alias: libmateweather
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: MATE-DE-tracker
TreeView+ depends on / blocked
 
Reported: 2012-08-13 08:20 UTC by Dan Mashal
Modified: 2012-09-17 22:48 UTC (History)
3 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2012-09-17 17:26:13 UTC
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Dan Mashal 2012-08-13 08:20:26 UTC
Spec URL: http://vicodan.fedorapeople.org/matespec/libmateweather.spec
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/libmateweather-1.4.0-1.fc17.src.rpm
Description: Libraries to allow MATE Desktop to display weather information

Comment 1 leigh scott 2012-08-13 19:40:47 UTC
You don't own %{_datadir}/icons/mate/ (mate-icon-theme owns it)

%files -f %{name}.lang
%doc AUTHORS COPYING README
%config(noreplace) %{_sysconfdir}/mateconf/schemas/mateweather.schemas
%{_datadir}/libmateweather/
%{_datadir}/icons/mate/
%{_datadir}/gtk-doc/html/libmateweather/

Comment 2 Dan Mashal 2012-08-13 23:28:04 UTC
Thanks, Leigh.

Will fix that shortly.

Comment 4 Wolfgang Ulbrich 2012-08-19 08:13:02 UTC
This package has a mateconf schema.
%{_sysconfdir}/mateconf/schemas/mateweather.schemas
You've to add this in scriplet section. see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf

Note, the package from my repo use old scriplet style, so updating for f16/f17 will fail. See my comment in mate-notification-daemon.

Comment 5 Dan Mashal 2012-08-19 08:14:19 UTC
You're right. Will fix.

Comment 6 leigh scott 2012-08-19 08:43:12 UTC
(In reply to comment #5)
> You're right. Will fix.

Move this to -devel where it belongs


%{_libdir}/libmateweather.so

and this can be removed from the -devel requires

Requires:	%{name}%{?_isa} = %{version}-%{release}


as the -libs package already requires it

Comment 7 Rex Dieter 2012-08-24 16:02:58 UTC
Some initial  comments:

1. SHOULD drop  -libs subpkg,  it's already  named lib*,  and it's contents have little/no chance to induce multilib conflicts

2.  MUST move
%{python_sitearch}/mateweather/
to main pkg,  fairly certain these are for runtime use (not -devel purposes)

3.  per comment #4, MUST add mateconf schema scriptlets

Comment 8 Dan Mashal 2012-08-26 03:19:58 UTC
Fixed.

Spec URL: http://vicodan.fedorapeople.org/matespec/libmateweather.spec
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/libmateweather-1.4.0-3.fc17.src.rpm
Description: Libraries to allow MATE Desktop to display weather information

Comment 9 Rex Dieter 2012-08-26 03:23:19 UTC
The schema scriptlets look wrong, this is what I see in mate-vfs for example,

%pre
%mateconf_schema_prepare ...

%preun
%mateconf_schema_remove ...

%post
%mateconf_schema_upgrade ...

Comment 10 Dan Mashal 2012-08-26 22:33:03 UTC
Fixed. 

Fixed.

Spec URL: http://vicodan.fedorapeople.org/matespec/libmateweather.spec
SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/libmateweather-1.4.0-4.fc17.src.rpm
Description: Libraries to allow MATE Desktop to display weather information

Comment 11 Rex Dieter 2012-08-26 23:48:26 UTC
Good thanks,

APPROVED.

Comment 12 Dan Mashal 2012-08-26 23:52:49 UTC
New Package SCM Request
=======================
Package Name: libmateweather
Short Description: Libraries to allow MATE Desktop to display weather information
Owners: vicodan rdieter
Branches: f16 f17 f18

Comment 13 Gwyn Ciesla 2012-08-27 01:47:09 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2012-08-27 03:18:38 UTC
libmateweather-1.4.0-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/libmateweather-1.4.0-4.fc18

Comment 15 Fedora Update System 2012-08-27 03:20:17 UTC
libmateweather-1.4.0-4.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/libmateweather-1.4.0-4.fc17

Comment 16 Fedora Update System 2012-08-27 16:31:09 UTC
libmateweather-1.4.0-5.fc18 has been pushed to the Fedora 18 testing repository.

Comment 17 Fedora Update System 2012-09-17 17:26:13 UTC
libmateweather-1.4.0-5.fc17 has been pushed to the Fedora 17 stable repository.

Comment 18 Fedora Update System 2012-09-17 22:48:43 UTC
libmateweather-1.4.0-5.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.