Bug 848074

Summary:	[Storage] Attaching illegal disks to VM must be prohibited.
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Leonid Natapov <lnatapov>
Component:	ovirt-engine	Assignee:	Maor <mlipchuk>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Dafna Ron <dron>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.1.0	CC:	abaron, amureini, dyasny, hateya, iheim, lpeer, mkenneth, mlipchuk, Rhev-m-bugs, yeylon, ykaul
Target Milestone:	---
Target Release:	3.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	storage
Fixed In Version:	SI15	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	851201 (view as bug list)		Environment:
Last Closed:	2012-12-04 20:03:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Leonid Natapov 2012-08-14 14:11:13 UTC

[Storage] Attaching illegal disks to VM must be prohibited.

IF for some reason disk that was attached to VM wasn't removed while VM deletion,we mark this disk as "illegal".
Now,we can attach illegal disk to another VM. This must be prohibited. Illegak disks can not be attached to VMs.

Comment 2 Maor 2012-08-15 14:27:05 UTC

post to upstream at http://gerrit.ovirt.org/#/c/7205/

Comment 3 Maor 2012-08-16 13:25:55 UTC

Merged upstream at 7130a5c782aa2810cf92978e410443bf05a94f77

Comment 5 Leonid Natapov 2012-08-22 14:24:58 UTC

How to reproduce:

1.Create VM with 10 disks.
2.Remove this VM and at the same time do restart to vdsmd on the host.

Because of restarting vdsmd some of vm's disks won't be removed and will be marked as illegal disks in the Disks tab.

After that try to attach disk to another VM. Make sure that no illegal disks appear in the "add disk" dialog.

Comment 6 Maor 2012-08-23 13:27:52 UTC

The fix adds validation when attaching illegal disks.(In reply to comment #5)
> How to reproduce:
> 
> 1.Create VM with 10 disks.
> 2.Remove this VM and at the same time do restart to vdsmd on the host.
> 
> Because of restarting vdsmd some of vm's disks won't be removed and will be
> marked as illegal disks in the Disks tab.
> 
> After that try to attach disk to another VM. Make sure that no illegal disks
> appear in the "add disk" dialog.
The fix adds validation when attaching illegal disks.

Comment 7 Dafna Ron 2012-08-23 13:33:56 UTC

verified on si15 that we cannot attach the disks with illegal state with CanDoAction. 
cloning this bug to webadmin to filter these disks from the results of add disk.