we are currently blocking attach of disks in illegal state which is good for api users. but for webadmin users it would be better if we filter the illegal disks from the add disk dialogue when trying to attach. 
=============================================================================




+++ This bug was initially created as a clone of Bug #848074 +++

[Storage] Attaching illegal disks to VM must be prohibited.

IF for some reason disk that was attached to VM wasn't removed while VM deletion,we mark this disk as "illegal".
Now,we can attach illegal disk to another VM. This must be prohibited. Illegak disks can not be attached to VMs.

--- Additional comment from pm-rhel on 2012-08-15 03:53:06 EDT ---

This request has been proposed as an exception, but a release flag has
not been requested. Please set a release flag to ? to ensure we may
track this bug against the appropriate upcoming release, and reset the
exception flag to ?.

--- Additional comment from mlipchuk on 2012-08-15 10:27:05 EDT ---

post to upstream at http://gerrit.ovirt.org/#/c/7205/

--- Additional comment from mlipchuk on 2012-08-16 09:25:55 EDT ---

Merged upstream at 7130a5c782aa2810cf92978e410443bf05a94f77

--- Additional comment from amureini on 2012-08-19 09:27:34 EDT ---

merged downstream, https://gerrit.eng.lab.tlv.redhat.com/#/c/1345/

--- Additional comment from lnatapov on 2012-08-22 10:24:58 EDT ---

How to reproduce:

1.Create VM with 10 disks.
2.Remove this VM and at the same time do restart to vdsmd on the host.

Because of restarting vdsmd some of vm's disks won't be removed and will be marked as illegal disks in the Disks tab.

After that try to attach disk to another VM. Make sure that no illegal disks appear in the "add disk" dialog.

--- Additional comment from mlipchuk on 2012-08-23 09:27:52 EDT ---

The fix adds validation when attaching illegal disks.(In reply to comment #5)
> How to reproduce:
> 
> 1.Create VM with 10 disks.
> 2.Remove this VM and at the same time do restart to vdsmd on the host.
> 
> Because of restarting vdsmd some of vm's disks won't be removed and will be
> marked as illegal disks in the Disks tab.
> 
> After that try to attach disk to another VM. Make sure that no illegal disks
> appear in the "add disk" dialog.
The fix adds validation when attaching illegal disks.

--- Additional comment from dron on 2012-08-23 09:33:56 EDT ---

verified on si15 that we cannot attach the disks with illegal state with CanDoAction. 
cloning this bug to webadmin to filter these disks from the results of add disk.