[Storage] Attaching illegal disks to VM must be prohibited. IF for some reason disk that was attached to VM wasn't removed while VM deletion,we mark this disk as "illegal". Now,we can attach illegal disk to another VM. This must be prohibited. Illegak disks can not be attached to VMs.
post to upstream at http://gerrit.ovirt.org/#/c/7205/
Merged upstream at 7130a5c782aa2810cf92978e410443bf05a94f77
How to reproduce: 1.Create VM with 10 disks. 2.Remove this VM and at the same time do restart to vdsmd on the host. Because of restarting vdsmd some of vm's disks won't be removed and will be marked as illegal disks in the Disks tab. After that try to attach disk to another VM. Make sure that no illegal disks appear in the "add disk" dialog.
The fix adds validation when attaching illegal disks.(In reply to comment #5) > How to reproduce: > > 1.Create VM with 10 disks. > 2.Remove this VM and at the same time do restart to vdsmd on the host. > > Because of restarting vdsmd some of vm's disks won't be removed and will be > marked as illegal disks in the Disks tab. > > After that try to attach disk to another VM. Make sure that no illegal disks > appear in the "add disk" dialog. The fix adds validation when attaching illegal disks.
verified on si15 that we cannot attach the disks with illegal state with CanDoAction. cloning this bug to webadmin to filter these disks from the results of add disk.