Bug 857724
| Summary: | Review Request: php53-simplepie.spec - Simple RSS Library in PHP | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matěj Cepl <mcepl> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cfeller, david, fedora, mcepl, notting, package-review, pcfe, redhat-bugzilla |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-03-26 16:39:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 857722, 862770, 905174 | ||
| Bug Blocks: | 855156, 891717 | ||
|
Description
Matěj Cepl
2012-09-16 14:57:20 UTC
OK, I got back to wordpress 3.1.4 using php, but I have YUM griping at me every hour about updating to wordpress 3.5.1 but it can't because it can't find php53-simplepie yet. Please advise. Thanks. @Matěj why do you submit old version 1.2 instead of 1.3, requires by wordpress ? (In reply to comment #2) > @Matěj why do you submit old version 1.2 instead of 1.3, requires by > wordpress ? Because I have posted it on 2012-09-16? Is http://koji.fedoraproject.org/koji/taskinfo?taskID=4845449 (spec file is at the same URL) any better? @Robert : are you going to do the review soon ? (else release it, and I will proceed) Remi, if you have time, simply pick it up and reassign it to you. You cannot requires (for ex.) php53-curl which is not a package (and provided). Per Guildelines you should requires all the "needed" extensions, so php-curl (which is provided both by php-common and php53-common) Of course, you need to also requires php53-common to ensure minimal version (5.2.0 according to upstream), until we have, as in fedora, the php(language) provided by php in RHEL (pending). So: # to ensure minimal PHP version Requires: php53-common # extensions required Requires: php-IDNA_Convert Requires: php-curl Requires: php-date Requires: php-dom Requires: php-iconv Requires: php-libxml Requires: php-mbstring Requires: php-pcre Requires: php-pdo Requires: php-reflection Requires: php-xml I'm also confused by https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-0007 I don't think you can push php-simplepie 1.3.1 in EPEL-5 (else this package won't be needed) (In reply to comment #7) > You cannot requires (for ex.) php53-curl which is not a package (and > provided). > > Per Guildelines you should requires all the "needed" extensions, so php-curl > (which is provided both by php-common and php53-common) Something like this http://koji.fedoraproject.org/koji/taskinfo?taskID=4850885 (SPEC file in the same URL)? > I'm also confused by > https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-0007 > I don't think you can push php-simplepie 1.3.1 in EPEL-5 (else this package > won't be needed) Unpushed. $ diff php53-simplepie.spec.0 php53-simplepie.spec
9c9
< Release: 3%{?dist}
---
> Release: 4%{?dist}
26,36c26,27
< Requires: php53-IDNA_Convert
< Requires: php53-curl
< Requires: php53-date
< Requires: php53-dom
< Requires: php53-iconv
< Requires: php53-libxml
< Requires: php53-mbstring
< Requires: php53-pcre
< Requires: php53-pdo
< Requires: php53-reflection
< Requires: php53-xml
---
> # To get standard requires packages
> Requires: php53-common
86a78,80
> * Wed Jan 09 2013 Matěj Cepl <mcepl> - 1.3.1-4
> - Fix requires.
>
Why have you remove all the requires for needed extensions ?
You really need them
Another try http://koji.fedoraproject.org/koji/taskinfo?taskID=4852160 (and .spec file in the same place) $ diff php53-simplepie.spec.1 php53-simplepie.spec
9c9
< Release: 4%{?dist}
---
> Release: 5%{?dist}
27a28
> Requires: php53-mbstring, php53-xml, php53-pdo, php-IDNA_Convert
77a79,81
> * Wed Jan 09 2013 Matěj Cepl <mcepl> - 1.3.1-5
> - Another try of fixing Requires.
>
Test installation on RHEL 5.9 : OK.
$ diff php-simplepie.spec php53-simplepie.spec 7c7 < Name: php-simplepie --- > Name: php53-simplepie 9c9 < Release: 3%{?dist} --- > Release: 5%{?dist} 15,16c15 < Source0: http://simplepie.org/downloads/simplepie_%{version}.zip < --- > Source0: https://nodeload.github.com/simplepie/simplepie/legacy.zip/%{version} 21a21 > 26,36c26,28 < Requires: php-IDNA_Convert < Requires: php-curl < Requires: php-date < Requires: php-dom < Requires: php-iconv < Requires: php-libxml < Requires: php-mbstring < Requires: php-pcre < Requires: php-pdo < Requires: php-reflection < Requires: php-xml --- > # To get standard requires packages > Requires: php53-common > Requires: php53-mbstring, php53-xml, php53-pdo, php-IDNA_Convert Minimal review as this is an adaptation of an existing package. No Blocker, requires are fine. ==== APPROVED ==== FWIW (on a CentOS 5 box): php-IDNA_Convert pulls in php-common [...] ---> Package php-IDNA_Convert.noarch 0:0.6.3-2.el5 set to be updated --> Processing Dependency: php for package: php-IDNA_Convert [...] and then I run into php53-common conflicts with php-common Also tried with the latest I found on koji (php-IDNA_Convert-0.8.0-1.el5.noarch.rpm), still get the conflict on ...-common # yum info php53-common php-common [...] Installed Packages Name : php53-common Arch : x86_64 Version : 5.3.3 Release : 13.el5_8 Size : 2.9 M Repo : installed [...] Available Packages Name : php-common Arch : x86_64 Version : 5.1.6 Release : 39.el5_8 Size : 154 k Repo : updates [...] Please publish the full yum output. (In reply to comment #14) > Please publish the full yum output. # yum localinstall php53-simplepie-1.3.1-5.el5.noarch.rpm Loaded plugins: downloadonly, fastestmirror Setting up Local Package Process Examining php53-simplepie-1.3.1-5.el5.noarch.rpm: php53-simplepie-1.3.1-5.el5.noarch Marking php53-simplepie-1.3.1-5.el5.noarch.rpm to be installed Loading mirror speeds from cached hostfile * base: mirror.softaculous.com * epel: mirror.de.leaseweb.net * extras: mirror.softaculous.com * updates: mirror.softaculous.com Resolving Dependencies --> Running transaction check ---> Package php53-simplepie.noarch 0:1.3.1-5.el5 set to be updated --> Processing Dependency: php-IDNA_Convert for package: php53-simplepie --> Processing Dependency: php53-mbstring for package: php53-simplepie --> Processing Dependency: php53-pdo for package: php53-simplepie --> Processing Dependency: php53-xml for package: php53-simplepie --> Running transaction check ---> Package php-IDNA_Convert.noarch 0:0.6.3-2.el5 set to be updated --> Processing Dependency: php for package: php-IDNA_Convert ---> Package php53-mbstring.x86_64 0:5.3.3-13.el5_8 set to be updated ---> Package php53-pdo.x86_64 0:5.3.3-13.el5_8 set to be updated ---> Package php53-xml.x86_64 0:5.3.3-13.el5_8 set to be updated --> Running transaction check ---> Package php.x86_64 0:5.1.6-39.el5_8 set to be updated --> Processing Dependency: php-common = 5.1.6-39.el5_8 for package: php --> Processing Dependency: php-cli = 5.1.6-39.el5_8 for package: php --> Running transaction check ---> Package php-cli.x86_64 0:5.1.6-39.el5_8 set to be updated ---> Package php-common.x86_64 0:5.1.6-39.el5_8 set to be updated --> Processing Conflict: php53-common conflicts php-common --> Finished Dependency Resolution php53-common-5.3.3-13.el5_8.x86_64 from installed has depsolving problems --> php53-common conflicts with php-common Error: php53-common conflicts with php-common You could try using --skip-broken to work around the problem You could try running: package-cleanup --problems package-cleanup --dupes rpm -Va --nofiles --nodigest You have to wait for php-IDNA_Convert-0.8.0-1.el5 or pull it from epel-testing. (In reply to comment #16) > You have to wait for php-IDNA_Convert-0.8.0-1.el5 or pull it from > epel-testing. Thanks. With php-IDNA_Convert-0.8.0-1.el5 I was able to install php53-simplepie-1.3.1-5.el5 As this package is approved for a long time, can you please push it ASAP in EPEL-5 to fix workpress broken deps ? New Package SCM Request ======================= Package Name: php53-simplepie Short Description: Simple RSS Library in PHP Owners: remi Branches: EL-5 InitialCC: mcepl Git done (by process-git-requests). php53-simplepie-1.3.1-5.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/php53-simplepie-1.3.1-5.el5 php53-simplepie-1.3.1-5.el5 has been pushed to the Fedora EPEL 5 testing repository. php53-simplepie-1.3.1-5.el5 has been pushed to the Fedora EPEL 5 stable repository. |