Bug 857724 - Review Request: php53-simplepie.spec - Simple RSS Library in PHP
Summary: Review Request: php53-simplepie.spec - Simple RSS Library in PHP
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 857722 862770 905174
Blocks: 855156 891717
TreeView+ depends on / blocked
 
Reported: 2012-09-16 14:57 UTC by Matěj Cepl
Modified: 2018-04-11 11:20 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-26 16:39:16 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Matěj Cepl 2012-09-16 14:57:20 UTC
Spec URL: http://mcepl.fedorapeople.org/tmp/php53-simplepie.spec
SRPM URL: http://mcepl.fedorapeople.org/tmp/php53-simplepie-1.2-3.el5.src.rpm
Fedora Account System Username: mcepl
Description: 
SimplePie is a very fast and easy-to-use class, written in PHP, that puts the
'simple' back into 'really simple syndication'. Flexible enough to suit
beginners and veterans alike, SimplePie is focused on speed, ease of use,
compatibility and standards compliance.

Comment 1 David Summers 2013-01-04 19:53:49 UTC
OK, I got back to wordpress 3.1.4 using php, but I have YUM griping at me every hour about updating to wordpress 3.5.1 but it can't because it can't find php53-simplepie yet.

Please advise.

Thanks.

Comment 2 Remi Collet 2013-01-07 07:47:56 UTC
@Matěj why do you submit old version 1.2 instead of 1.3, requires by wordpress ?

Comment 3 Matěj Cepl 2013-01-07 12:02:23 UTC
(In reply to comment #2)
> @Matěj why do you submit old version 1.2 instead of 1.3, requires by
> wordpress ?

Because I have posted it on 2012-09-16?

Comment 4 Matěj Cepl 2013-01-07 14:57:17 UTC
Is http://koji.fedoraproject.org/koji/taskinfo?taskID=4845449 (spec file is at the same URL) any better?

Comment 5 Remi Collet 2013-01-07 15:04:45 UTC
@Robert : are you going to do the review soon ?
(else release it, and I will proceed)

Comment 6 Robert Scheck 2013-01-07 15:08:41 UTC
Remi, if you have time, simply pick it up and reassign it to you.

Comment 7 Remi Collet 2013-01-08 08:51:24 UTC
You cannot requires (for ex.) php53-curl which is not a package (and provided).

Per Guildelines you should requires all the "needed" extensions, so php-curl (which is provided both by php-common and php53-common)

Of course, you need to also requires php53-common to ensure minimal version (5.2.0 according to upstream), until we have, as in fedora, the php(language) provided by php in RHEL (pending).

So:

# to ensure minimal PHP version 
Requires:	php53-common
# extensions required
Requires:	php-IDNA_Convert
Requires:	php-curl
Requires:	php-date
Requires:	php-dom
Requires:	php-iconv
Requires:	php-libxml
Requires:	php-mbstring
Requires:	php-pcre
Requires:	php-pdo
Requires:	php-reflection
Requires:	php-xml

I'm also confused by https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-0007
I don't think you can push php-simplepie 1.3.1 in EPEL-5 (else this package won't be needed)

Comment 8 Matěj Cepl 2013-01-09 09:46:33 UTC
(In reply to comment #7)
> You cannot requires (for ex.) php53-curl which is not a package (and
> provided).
> 
> Per Guildelines you should requires all the "needed" extensions, so php-curl
> (which is provided both by php-common and php53-common)

Something like this http://koji.fedoraproject.org/koji/taskinfo?taskID=4850885 (SPEC file in the same URL)?

> I'm also confused by
> https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-0007
> I don't think you can push php-simplepie 1.3.1 in EPEL-5 (else this package
> won't be needed)

Unpushed.

Comment 9 Remi Collet 2013-01-09 09:59:58 UTC
$ diff php53-simplepie.spec.0 php53-simplepie.spec
9c9
< Release:	3%{?dist}
---
> Release:	4%{?dist}
26,36c26,27
< Requires:	php53-IDNA_Convert
< Requires:	php53-curl
< Requires:	php53-date
< Requires:	php53-dom
< Requires:	php53-iconv
< Requires:	php53-libxml
< Requires:	php53-mbstring
< Requires:	php53-pcre
< Requires:	php53-pdo
< Requires:	php53-reflection
< Requires:	php53-xml
---
> # To get standard requires packages
> Requires:	php53-common
86a78,80
> * Wed Jan 09 2013 Matěj Cepl <mcepl> - 1.3.1-4
> - Fix requires.
> 

Why have you remove all the requires for needed extensions ?
You really need them

Comment 10 Matěj Cepl 2013-01-09 17:43:14 UTC
Another try
http://koji.fedoraproject.org/koji/taskinfo?taskID=4852160 (and .spec file in the same place)

Comment 11 Remi Collet 2013-01-09 18:04:09 UTC
$ diff php53-simplepie.spec.1 php53-simplepie.spec
9c9
< Release:	4%{?dist}
---
> Release:	5%{?dist}
27a28
> Requires:   php53-mbstring, php53-xml, php53-pdo, php-IDNA_Convert
77a79,81
> * Wed Jan 09 2013 Matěj Cepl <mcepl> - 1.3.1-5
> - Another try of fixing Requires.
> 


Test installation on RHEL 5.9 : OK.

Comment 12 Remi Collet 2013-01-09 18:06:21 UTC
$ diff php-simplepie.spec php53-simplepie.spec
7c7
< Name:		php-simplepie
---
> Name:		php53-simplepie
9c9
< Release:	3%{?dist}
---
> Release:	5%{?dist}
15,16c15
< Source0:	http://simplepie.org/downloads/simplepie_%{version}.zip
< 
---
> Source0: https://nodeload.github.com/simplepie/simplepie/legacy.zip/%{version}
21a21
> 
26,36c26,28
< Requires:	php-IDNA_Convert
< Requires:	php-curl
< Requires:	php-date
< Requires:	php-dom
< Requires:	php-iconv
< Requires:	php-libxml
< Requires:	php-mbstring
< Requires:	php-pcre
< Requires:	php-pdo
< Requires:	php-reflection
< Requires:	php-xml
---
> # To get standard requires packages
> Requires:	php53-common
> Requires:   php53-mbstring, php53-xml, php53-pdo, php-IDNA_Convert

Minimal review as this is an adaptation of an existing package.

No Blocker, requires are fine.

==== APPROVED ====

Comment 13 Patrick C. F. Ernzer 2013-01-11 12:04:39 UTC
FWIW (on a CentOS 5 box):

php-IDNA_Convert pulls in php-common
[...]
---> Package php-IDNA_Convert.noarch 0:0.6.3-2.el5 set to be updated
--> Processing Dependency: php for package: php-IDNA_Convert
[...]

and then I run into php53-common conflicts with php-common

Also tried with the latest I found on koji (php-IDNA_Convert-0.8.0-1.el5.noarch.rpm), still get the conflict on ...-common

# yum info php53-common php-common
[...]
Installed Packages
Name       : php53-common
Arch       : x86_64
Version    : 5.3.3
Release    : 13.el5_8
Size       : 2.9 M
Repo       : installed
[...]

Available Packages
Name       : php-common
Arch       : x86_64
Version    : 5.1.6
Release    : 39.el5_8
Size       : 154 k
Repo       : updates
[...]

Comment 14 Remi Collet 2013-01-11 12:42:54 UTC
Please publish the full yum output.

Comment 15 Patrick C. F. Ernzer 2013-01-14 11:19:38 UTC
(In reply to comment #14)
> Please publish the full yum output.

# yum localinstall php53-simplepie-1.3.1-5.el5.noarch.rpm
Loaded plugins: downloadonly, fastestmirror
Setting up Local Package Process
Examining php53-simplepie-1.3.1-5.el5.noarch.rpm: php53-simplepie-1.3.1-5.el5.noarch
Marking php53-simplepie-1.3.1-5.el5.noarch.rpm to be installed
Loading mirror speeds from cached hostfile
 * base: mirror.softaculous.com
 * epel: mirror.de.leaseweb.net
 * extras: mirror.softaculous.com
 * updates: mirror.softaculous.com
Resolving Dependencies
--> Running transaction check
---> Package php53-simplepie.noarch 0:1.3.1-5.el5 set to be updated
--> Processing Dependency: php-IDNA_Convert for package: php53-simplepie
--> Processing Dependency: php53-mbstring for package: php53-simplepie
--> Processing Dependency: php53-pdo for package: php53-simplepie
--> Processing Dependency: php53-xml for package: php53-simplepie
--> Running transaction check
---> Package php-IDNA_Convert.noarch 0:0.6.3-2.el5 set to be updated
--> Processing Dependency: php for package: php-IDNA_Convert
---> Package php53-mbstring.x86_64 0:5.3.3-13.el5_8 set to be updated
---> Package php53-pdo.x86_64 0:5.3.3-13.el5_8 set to be updated
---> Package php53-xml.x86_64 0:5.3.3-13.el5_8 set to be updated
--> Running transaction check
---> Package php.x86_64 0:5.1.6-39.el5_8 set to be updated
--> Processing Dependency: php-common = 5.1.6-39.el5_8 for package: php
--> Processing Dependency: php-cli = 5.1.6-39.el5_8 for package: php
--> Running transaction check
---> Package php-cli.x86_64 0:5.1.6-39.el5_8 set to be updated
---> Package php-common.x86_64 0:5.1.6-39.el5_8 set to be updated
--> Processing Conflict: php53-common conflicts php-common
--> Finished Dependency Resolution
php53-common-5.3.3-13.el5_8.x86_64 from installed has depsolving problems
  --> php53-common conflicts with php-common
Error: php53-common conflicts with php-common
 You could try using --skip-broken to work around the problem
 You could try running: package-cleanup --problems
                        package-cleanup --dupes
                        rpm -Va --nofiles --nodigest

Comment 16 Remi Collet 2013-01-14 11:56:24 UTC
You have to wait for php-IDNA_Convert-0.8.0-1.el5 or pull it from epel-testing.

Comment 17 Patrick C. F. Ernzer 2013-01-29 17:38:58 UTC
(In reply to comment #16)
> You have to wait for php-IDNA_Convert-0.8.0-1.el5 or pull it from
> epel-testing.

Thanks. With php-IDNA_Convert-0.8.0-1.el5 I was able to install php53-simplepie-1.3.1-5.el5

Comment 18 Remi Collet 2013-03-10 08:43:08 UTC
As this package is approved for a long time, can you please push it ASAP in EPEL-5 to fix workpress broken deps ?

Comment 19 Matěj Cepl 2013-03-11 13:19:21 UTC
New Package SCM Request
=======================
Package Name: php53-simplepie
Short Description: Simple RSS Library in PHP
Owners: remi
Branches: EL-5
InitialCC: mcepl

Comment 20 Gwyn Ciesla 2013-03-11 13:33:14 UTC
Git done (by process-git-requests).

Comment 21 Fedora Update System 2013-03-11 13:57:24 UTC
php53-simplepie-1.3.1-5.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/php53-simplepie-1.3.1-5.el5

Comment 22 Fedora Update System 2013-03-11 19:36:56 UTC
php53-simplepie-1.3.1-5.el5 has been pushed to the Fedora EPEL 5 testing repository.

Comment 23 Fedora Update System 2013-03-26 16:39:19 UTC
php53-simplepie-1.3.1-5.el5 has been pushed to the Fedora EPEL 5 stable repository.


Note You need to log in before you can comment on or make changes to this bug.