Bug 870502

+++ This bug was initially created as a clone of Bug #764678 +++

gsyncd uses os.spawn* family of functions to invoke helper programs. These functions have poor feedback capabilites. Should move to a more comprehensive approach, which could feature:

- detect if command is not possible to invoke (execve failure)
- refine handling of result beyond the "success / failure" dichotomy
- reuse error messages of external programs as log messages

Most likely candidate is subprocess module, but it's not yet investigated if it's really suitable (beyond its availability in Python >= 2.4).

--- Additional comment from aavati on 2011-08-25 05:36:47 EDT ---

CHANGE: http://review.gluster.com/85 (Use subprocess module instead of os.spawn* / ad-hoc fork/exec.) merged in master by Vijay Bellur (vijay)

--- Additional comment from aavati on 2012-05-19 09:11:58 EDT ---

CHANGE: http://review.gluster.com/3258 (geo-rep / gsyncd: fixes regarding the command invocation framework) merged in master by Vijay Bellur (vijay)

--- Additional comment from vbellur on 2012-07-09 00:14:40 EDT ---

CHANGE: http://review.gluster.com/3563 (geo-rep / gsyncd: sanitize error log of external commands) merged in release-3.3 by Vijay Bellur (vijay)

--- Additional comment from vbellur on 2012-07-15 00:08:33 EDT ---

CHANGE: http://review.gluster.com/3561 (geo-rep / gsyncd: sanitize error log of external commands) merged in master by Anand Avati (avati)

--- Additional comment from vbellur on 2012-07-15 00:09:48 EDT ---

CHANGE: http://review.gluster.com/3560 (geo-rep / gsyncd: fixes to communication with child processes) merged in master by Anand Avati (avati)

--- Additional comment from vbellur on 2012-07-16 05:50:36 EDT ---

CHANGE: http://review.gluster.com/3562 (geo-rep / gsyncd: fixes to communication with child processes) merged in release-3.3 by Vijay Bellur (vbellur)