Bug 873341
| Summary: | Keyboard input focus broken (mostly win key captured by both guest and client) | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Uri Lublin <uril> | |
| Component: | mingw-virt-viewer | Assignee: | Marc-Andre Lureau <marcandre.lureau> | |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | |
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 3.1.0 | CC: | acathrow, byount, cfergeau, cpelland, dblechte, marcandre.lureau, mkrcmari, pvine, tjamrisk, uril | |
| Target Milestone: | --- | Keywords: | Reopened | |
| Target Release: | 3.3.0 | |||
| Hardware: | Unspecified | |||
| OS: | Windows | |||
| Whiteboard: | ||||
| Fixed In Version: | mingw-virt-viewer-0.5.6-6.el6_4 | Doc Type: | Bug Fix | |
| Doc Text: |
When the Win key was pressed outside of virt-viewer, it was captured by both client and guest. Now virt-viewer does not handle special keys with a global hook when the keyboard is not grabbed. As a result, the Win key is captured only by Windows or by virt-viewer, and not both.
|
Story Points: | --- | |
| Clone Of: | 857389 | |||
| : | 973652 (view as bug list) | Environment: | ||
| Last Closed: | 2014-01-21 14:44:54 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 857389 | |||
| Bug Blocks: | 973652 | |||
|
Description
Uri Lublin
2012-11-05 15:32:24 UTC
no pm ack for 3.2, revert devel ack to ?, spice-gtk doesn't take the keyboard grab when the pointer is not over the application. iirc, this is to avoid to be trapped precisely when giving the focus with alt-tab, so that you can cycle again to other apps. The behaviour is the same on Linux. So, if we take the grab, windows won't catch the Win key press, but you won't be able to alt-tab = move out of the client the same way you entered it. Imho, no taking the grab is better than forcefully taking it whenever the client gets the focus (especially when the widget is embedded, for ex in virt-manager). This was originally written this way by Gerd in the very early version of spice-gtk. Apparently, gtk-vnc does something similar, only taking keyboard grab when entering the widget. I don't see a major issue if the win key is received by both client and guest (when the keyboard is not grabbed & the pointer is not over the display) Eventually, we can special-case on windows client, and filter out the Win key when not having the keyboard grab. RFC patch sent to the ML, does ok for me http://lists.freedesktop.org/archives/spice-devel/2013-April/012944.html The keyboard focus on windows clients is now completely strange. I've been under the impression that hovering cursor over area should capture it, as it does on linux. It doesn't. Unless the window is "selected" it doesn't intercept any keys. The worse part is, that alt-tab is no longer handled by guest (with windows 7 and 8 clients) and is instead always handled by client, regardless of focus. I'd say this needs further fixing and suggest moving it back to ASSIGNED (In reply to Tomas Jamrisko from comment #9) > The keyboard focus on windows clients is now completely strange. > > I've been under the impression that hovering cursor over area should capture > it, as it does on linux. It doesn't. Unless the window is "selected" it > doesn't intercept any keys. alt-tab seems broken, probably not because of that fix. win key isn't received by both guest and client, that was the point of this bug. Only by client when it has focus and mouse, which I think is the correct way. > > The worse part is, that alt-tab is no longer handled by guest (with windows > 7 and 8 clients) and is instead always handled by client, regardless of > focus. > > I'd say this needs further fixing and suggest moving it back to ASSIGNED I think alt-tab is a regression and should be a different bug instead. Fixed in, moving to POST: http://lists.freedesktop.org/archives/spice-devel/2013-September/014694.html This bug is currently attached to errata RHEA-2013:15512. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag. Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information: * Cause: What actions or circumstances cause this bug to present. * Consequence: What happens when the bug presents. * Fix: What was done to fix the bug. * Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore') Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug. For further details on the Cause, Consequence, Fix, Result format please refer to: https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes Thanks in advance. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-0034.html *** Bug 1001847 has been marked as a duplicate of this bug. *** |