Bug 886115

Summary: msgid "automatically attach this system to compatible subscriptions."
Product: Red Hat Enterprise Linux 5 Reporter: John Sefler <jsefler>
Component: subscription-managerAssignee: Bryan Kearney <bkearney>
Status: CLOSED ERRATA QA Contact: IDM QE LIST <seceng-idm-qe-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 5.10CC: alikins, bkearney, fsharath, hpeters, jgalipea
Target Milestone: beta   
Target Release: 5.10   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
No description necessary
 Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-30 22:53:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 840995, 920191    

Description John Sefler 2012-12-11 14:43:12 UTC 
Description of problem:

The following lines of code in subscription-manager/src/subscription_manager/managercli.py are cauing problems for the translation team.

>    864         self.parser.add_option("--auto-attach", action='store_true', dest="autoattach",
>    865                                help=_("automatically attach this system to\
>    866                                      compatible subscriptions."))

This line break is ugly when it gets extracted to subscription-manager/po/keys.pot...

>   1409 #: ../src/subscription_manager/managercli.py:864
>   1410 msgid ""
>   1411 "automatically attach this system to                                     "
>   1412 "compatible subscriptions."
>   1413 msgstr ""
                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                              NOTICE THE BLANK SPACES
The translation team does not know what to do with those blank spaces.


Please change the code to this:

self.parser.add_option("--auto-attach", action='store_true', dest="autoattach",
                       help=_("automatically attach this system to compatible subscriptions"))

AND, DROP THE PERIOD AT THE END OF THIS STRING SINCE IT IS AN OPTION DESCRIPTION (REF BUG 876692)


Version-Release number of selected component (if applicable):
[root@jsefler-6 ~]# rpm -q subscription-manager
subscription-manager-1.1.11-1.el6.x86_64
Comment 1 Adrian Likins 2012-12-13 22:34:16 UTC 
This will need a new string, but probably worth an exception.
Comment 2 Adrian Likins 2012-12-13 22:35:13 UTC 
*** Bug 886110 has been marked as a duplicate of this bug. ***
Comment 3 RHEL Program Management 2012-12-17 06:50:26 UTC 
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.
Comment 4 John Sefler 2012-12-18 20:57:53 UTC 
> [root@jsefler-6 LC_MESSAGES]# msgunfmt --no-wrap rhsm.mo | grep -i  "automatically attach"
> msgid "automatically attach compatible                                subscriptions to this system"
> msgid "automatically attach this system to                                     compatible subscriptions."


^^ These TWO msgids have too many spaces due to sloppy line continuation style within the python source code.

[root@jsefler-6 LC_MESSAGES]# rpm -q subscription-manager
subscription-manager-1.1.16-1.el6.x86_64
Comment 5 Bryan Kearney 2013-02-22 19:00:50 UTC 
https://github.com/candlepin/subscription-manager/pull/512
Comment 6 Bryan Kearney 2013-03-01 22:28:54 UTC 
commit 22ef8ddd3d0906c9172b59d88059c6fb8682bc77
Author: Bryan Kearney <bkearney>
Date:   Fri Feb 22 13:58:04 2013 -0500

    886115: Remove line continuations within strings.
    
    This causes issues for the translation team.
Comment 7 Sharath Dwaral 2013-03-15 15:26:56 UTC 
# rpm -qa | egrep "subscription-manager|python-rhsm"
subscription-manager-migration-1.8.4-1.git.27.a4c82ea.el7.x86_64
subscription-manager-1.8.4-1.git.27.a4c82ea.el7.x86_64
subscription-manager-debuginfo-1.8.4-1.el7.x86_64
subscription-manager-migration-data-1.13.0.0-1.git.3.fb64211.el7.noarch
subscription-manager-gui-1.8.4-1.git.27.a4c82ea.el7.x86_64
subscription-manager-firstboot-1.8.4-1.git.27.a4c82ea.el7.x86_64
python-rhsm-1.8.7-1.git.1.675a611.el7.x86_64

# msgunfmt --no-wrap /usr/share/locale/as/LC_MESSAGES/rhsm.mo | grep "automatically attach" -A1 -B1

msgid "automatically attach this system to compatible subscriptions."
msgstr "এই চিস্টেমক স্বচালিতভাৱে সংগত স্বাক্ষৰণসমূহৰ সৈতে সংলগ্ন কৰক।"

Verified
Comment 8 RHEL Program Management 2013-04-09 20:53:24 UTC 
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux release.  Product Management has
requested further review of this request by Red Hat Engineering, for
potential inclusion in a Red Hat Enterprise Linux release for currently
deployed products.  This request is not yet committed for inclusion in
a release.
Comment 10 errata-xmlrpc 2013-09-30 22:53:33 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1332.html