Bug 892433

Summary:	Review Request: perl-ParseUtil-Domain - Utility for parsing a domain name into its components
Product:	[Fedora] Fedora	Reporter:	Mathieu Bridon <mathieu>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-03-07 06:54:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	891139, 891152, 891165, 891873, 892423
Bug Blocks:

Description Mathieu Bridon 2013-01-07 05:54:52 UTC

Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-1.fc18.noarch.rpm
Description:
A tool for parsing domain names. This module makes use of the data provided
by the Public Suffix List (http://publicsuffix.org/list/) to parse tlds.

Fedora Account System Username: bochecha

Comment 1 Mathieu Bridon 2013-01-07 05:59:10 UTC

This requires a few other packages for which I have submitted reviews:
- perl-Net-IDN-Encode: bug 891139
- perl-Regexp-Assemble-Compressed: bug 891152
- perl-Test-Routine: bug 891165
- perl-Net-IDN-Nameprep: bug 891873
- perl-Perl6-Export-Attrs: bug 892423

Setting the "Depends On:" field accordingly.

Comment 2 Mathieu Bridon 2013-01-25 05:36:17 UTC

Here's a new package which fixes the issues that the two Petrs have been asking me to fix in my recent submissions, over and over and over and over and...

Thank you Petr and Petr.

Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.noarch.rpm

Comment 3 Petr Šabata 2013-03-05 17:13:59 UTC

(In reply to comment #2)
> http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.
> noarch.rpm

Correct link:
http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.src.rpm

Comment 4 Petr Šabata 2013-03-05 17:40:51 UTC

Missing BRs:
perl(base) from various sources
perl(lib) from various sources
perl(Moose) from t/lib/AsciiToggle.pm:3, t/lib/UnicodeToggle.pm:3
perl(Test::Routine::Util) from t/parse_ascii_test_routine.t:9

I suppose changing "tlds" to "TLDs" in the description would nice.

perl_default_filter is not necessary here.

The rest looks okay to me.

Comment 5 Mathieu Bridon 2013-03-06 04:35:47 UTC

(In reply to comment #3)
> (In reply to comment #2)
> > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.
> > noarch.rpm
> 
> Correct link:
> http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.
> src.rpm

Sorry about that.

(In reply to comment #4)
> Missing BRs:
> perl(base) from various sources
> perl(lib) from various sources
> perl(Moose) from t/lib/AsciiToggle.pm:3, t/lib/UnicodeToggle.pm:3
> perl(Test::Routine::Util) from t/parse_ascii_test_routine.t:9

Thanks, fixed.

> I suppose changing "tlds" to "TLDs" in the description would nice.

Agreed, fixed.

> perl_default_filter is not necessary here.

But does it cause any trouble?

If not, I'd rather keep it there, so that I don't forget to add it if it eventually becomes necessary in the future.

After all, it is a very good thing to have for many Perl packages...

----

Spec URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-3.fc19.src.rpm

Comment 6 Petr Šabata 2013-03-06 08:39:02 UTC

(In reply to comment #5)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.
> > > noarch.rpm
> > 
> > Correct link:
> > http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-2.fc19.
> > src.rpm
> 
> Sorry about that.

No worries.

> (In reply to comment #4)
> > Missing BRs:
> > perl(base) from various sources
> > perl(lib) from various sources
> > perl(Moose) from t/lib/AsciiToggle.pm:3, t/lib/UnicodeToggle.pm:3
> > perl(Test::Routine::Util) from t/parse_ascii_test_routine.t:9
> 
> Thanks, fixed.

Ack.

> > I suppose changing "tlds" to "TLDs" in the description would nice.
> 
> Agreed, fixed.

Ack.

> > perl_default_filter is not necessary here.
> 
> But does it cause any trouble?

Nope, it does not.

> If not, I'd rather keep it there, so that I don't forget to add it if it
> eventually becomes necessary in the future.
> 
> After all, it is a very good thing to have for many Perl packages...
> 
> ----
> 
> Spec URL:
> http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain.spec
> SRPM URL:
> http://bochecha.fedorapeople.org/packages/perl-ParseUtil-Domain-2.22-3.fc19.
> src.rpm

Approving.

Comment 7 Mathieu Bridon 2013-03-06 09:32:24 UTC

Thanks for the review Petr!

New Package SCM Request
=======================
Package Name: perl-ParseUtil-Domain
Short Description: Utility for parsing a domain name into its components
Owners: bochecha
Branches: devel
InitialCC: perl-sig

Comment 8 Gwyn Ciesla 2013-03-06 13:36:28 UTC

Git done (by process-git-requests).

Comment 9 Mathieu Bridon 2013-03-07 06:54:08 UTC

Thanks Jon for the Git process.

Package built in Rawhide, closing.