Spec URL: http://bochecha.fedorapeople.org/packages/perl-Perl6-Export-Attrs.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Perl6-Export-Attrs-0.0.3-1.fc18.src.rpm Description: Implements a Perl 5 native version of what the Perl 6 symbol export mechanism will look like. Fedora Account System Username: bochecha
Taking the review.
Issues: Add perl(Carp) to your build dependencies (lib/Perl6/Export/Attrs.pm:7) and perl(Attribute::Handlers) (lib/Perl6/Export/Attrs.pm:8). The rest of the package looks good.
(In reply to comment #2) > Issues: > > Add perl(Carp) to your build dependencies (lib/Perl6/Export/Attrs.pm:7) and > perl(Attribute::Handlers) (lib/Perl6/Export/Attrs.pm:8). I'm curious about the reason for adding these. They are not required to build the module, and they are not even used in the unit tests. Am I missing something?
They're used during the test phase, e.g. in the use_ok() test in t/00.load.t. This could fail if the modules aren't present in the buildroot.
(In reply to comment #4) > They're used during the test phase, e.g. in the use_ok() test in t/00.load.t. > This could fail if the modules aren't present in the buildroot. I see. It just so happens that they were in the buildroot (as dependencies of something else I suppose), so the tests didn't fail, but that could change in the future, so we might as well be safe now. Thanks for the explanation. :) Here is the new submission. Spec URL: http://bochecha.fedorapeople.org/packages/perl-Perl6-Export-Attrs.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Perl6-Export-Attrs-0.0.3-2.fc18.src.rpm
Exactly :) The new package fixes all the issues I've pointed out; approving.
New Package SCM Request ======================= Package Name: perl-Perl6-Export-Attrs Short Description: Perl 6 'is export(...)' trait as a Perl 5 attribute Owners: bochecha Branches: devel InitialCC: perl-sig
Git done (by process-git-requests).
Thanks for the review Petr, and thank you Jon for the Git processing. Package is built in Rawhide, closing.