Bug 903768 (php-PhpCollection)

Summary: Review Request: php-PhpCollection - General purpose collection library for PHP
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, notting, package-review
Target Milestone: ---Flags: fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-03-29 01:35:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 903766    
Bug Blocks:    
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2013-01-24 19:44:46 UTC 
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PhpCollection.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PhpCollection-0.1.0-1.fc18.src.rpm

Description:
This library adds basic collections for PHP.

Collections can be seen as more specialized arrays for which certain contracts
are guaranteed.

Supported Collections:
* Sequences
** Keys: numerical, consequentially increasing, no gaps
** Values: anything, duplicates allowed
** Classes: Sequence, SortedSequence
* Maps
** Keys: strings or objects, duplicate keys not allowed
** Values: anything, duplicates allowed
** Classes: Map, ObjectMap (not yet implemented)
* Sets (not yet implemented)
** Keys: not meaningful
** Values: anything, each value must be unique (===)
** Classes: Set

General Characteristics:
* Collections are mutable (new elements may be added, existing elements may be
  modified or removed). Specialized immutable versions may be added in the
  future though.
* Equality comparison between elements are always performed using the shallow
  comparison operator (===).
* Sorting algorithms are unstable, that means the order for equal elements is
  undefined (the default, and only PHP behavior).


Fedora Account System Username: siwinski
Comment 1 Remi Collet 2013-03-10 08:30:39 UTC 
Created attachment 707764 [details]
phpci.log

phpci version 2.13.2.
Comment 2 Remi Collet 2013-03-10 08:31:07 UTC 
Created attachment 707765 [details]
review.txt

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 903768
Comment 3 Remi Collet 2013-03-10 08:31:45 UTC 
[!]: Latest version is packaged.
	version 0.2.0 is tagged in guthub.


No blocker

=== APPROVED ===
Comment 4 Remi Collet 2013-03-10 09:23:25 UTC 
Sorry to have miss the License issue.

LICENSE is Apache 2.0: OK.
doc/LICENSE is BY-NC-ND (http://jmsyst.com/libs/parser-lib), this only apply to documentation (not provided in the rpm, but present in the src.rpm)...

As BY-NC-ND is explicitly rejected for fedora
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Bad_Licenses_3

you have to strip the doc folder from upstream tarball.
Comment 5 Shawn Iwinski 2013-03-16 22:09:57 UTC 
Spec changes: https://github.com/siwinski/rpms/commit/d57357672db2f920dabf5491fc5e45fdc81bc69e


SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PhpCollection.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PhpCollection-0.2.0-1.fc18.src.rpm
Comment 6 Remi Collet 2013-03-18 14:37:24 UTC 
LICENSE issue fixed

== APPROVED (again) ==
Comment 7 Remi Collet 2013-03-18 14:42:34 UTC 
Please add php-PhpCollection-strip.sh as Source1.
Comment 8 Shawn Iwinski 2013-03-18 14:59:51 UTC 
(In reply to comment #7)
> Please add php-PhpCollection-strip.sh as Source1.

Shoot!  I actually meant to do that.  I will add that after initial import.
Comment 9 Shawn Iwinski 2013-03-18 15:20:08 UTC 
THANKS for the review!


New Package SCM Request
=======================
Package Name: php-PhpCollection
Short Description: General purpose collection library for PHP
Owners: siwinski
Branches: f18 f19 el6
InitialCC:
Comment 10 Gwyn Ciesla 2013-03-18 15:24:13 UTC 
Git done (by process-git-requests).
Comment 11 Fedora Update System 2013-03-18 18:48:31 UTC 
php-PhpCollection-0.2.0-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-PhpCollection-0.2.0-2.el6
Comment 12 Fedora Update System 2013-03-18 18:48:55 UTC 
php-PhpCollection-0.2.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-PhpCollection-0.2.0-2.fc18
Comment 13 Fedora Update System 2013-03-18 22:29:48 UTC 
php-PhpCollection-0.2.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
Comment 14 Fedora Update System 2013-03-29 01:35:58 UTC 
php-PhpCollection-0.2.0-2.fc18 has been pushed to the Fedora 18 stable repository.
Comment 15 Fedora Update System 2013-04-03 02:02:54 UTC 
php-PhpCollection-0.2.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.