Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PhpCollection.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PhpCollection-0.1.0-1.fc18.src.rpm Description: This library adds basic collections for PHP. Collections can be seen as more specialized arrays for which certain contracts are guaranteed. Supported Collections: * Sequences ** Keys: numerical, consequentially increasing, no gaps ** Values: anything, duplicates allowed ** Classes: Sequence, SortedSequence * Maps ** Keys: strings or objects, duplicate keys not allowed ** Values: anything, duplicates allowed ** Classes: Map, ObjectMap (not yet implemented) * Sets (not yet implemented) ** Keys: not meaningful ** Values: anything, each value must be unique (===) ** Classes: Set General Characteristics: * Collections are mutable (new elements may be added, existing elements may be modified or removed). Specialized immutable versions may be added in the future though. * Equality comparison between elements are always performed using the shallow comparison operator (===). * Sorting algorithms are unstable, that means the order for equal elements is undefined (the default, and only PHP behavior). Fedora Account System Username: siwinski
Created attachment 707764 [details] phpci.log phpci version 2.13.2.
Created attachment 707765 [details] review.txt Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 903768
[!]: Latest version is packaged. version 0.2.0 is tagged in guthub. No blocker === APPROVED ===
Sorry to have miss the License issue. LICENSE is Apache 2.0: OK. doc/LICENSE is BY-NC-ND (http://jmsyst.com/libs/parser-lib), this only apply to documentation (not provided in the rpm, but present in the src.rpm)... As BY-NC-ND is explicitly rejected for fedora https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Bad_Licenses_3 you have to strip the doc folder from upstream tarball.
Spec changes: https://github.com/siwinski/rpms/commit/d57357672db2f920dabf5491fc5e45fdc81bc69e SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PhpCollection.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PhpCollection-0.2.0-1.fc18.src.rpm
LICENSE issue fixed == APPROVED (again) ==
Please add php-PhpCollection-strip.sh as Source1.
(In reply to comment #7) > Please add php-PhpCollection-strip.sh as Source1. Shoot! I actually meant to do that. I will add that after initial import.
THANKS for the review! New Package SCM Request ======================= Package Name: php-PhpCollection Short Description: General purpose collection library for PHP Owners: siwinski Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
php-PhpCollection-0.2.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-PhpCollection-0.2.0-2.el6
php-PhpCollection-0.2.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-PhpCollection-0.2.0-2.fc18
php-PhpCollection-0.2.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
php-PhpCollection-0.2.0-2.fc18 has been pushed to the Fedora 18 stable repository.
php-PhpCollection-0.2.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.