Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PhpOption.spec
SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PhpOption-1.1.0-1.fc18.src.rpm
This package adds an Option type for PHP.
The Option type is intended for cases where you sometimes might return a value
(typically an object), and sometimes you might return no value (typically null)
depending on arguments, or other runtime factors.
Often times, you forget to handle the case where no value is returned. Not
intentionally of course, but maybe you did not account for all possible states
of the system; or maybe you indeed covered all cases, then time goes on, code
is refactored, some of these your checks might become invalid, or incomplete.
Suddenly, without noticing, the no value case is not handled anymore. As a
result, you might sometimes get fatal PHP errors telling you that you called a
method on a non-object; users might see blank pages, or worse.
On one hand, the Option type forces a developer to consciously think about both
cases (returning a value, or returning no value). That in itself will already
make your code more robust. On the other hand, the Option type also allows the
API developer to provide more concise API methods, and empowers the API user in
how he consumes these methods.
Fedora Account System Username: siwinski
Created attachment 687489 [details]
Created attachment 687490 [details]
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-x86_64
Command line :/usr/bin/fedora-review -b 903766
All seems correct.
=== APPROVED ===
THANKS for the review!
New Package SCM Request
Package Name: php-PhpOption
Short Description: Option type for PHP
Branches: f18 el6
Git done (by process-git-requests).
php-PhpOption-1.1.0-1.fc18 has been submitted as an update for Fedora 18.
php-PhpOption-1.1.0-1.el6 has been submitted as an update for Fedora EPEL 6.
php-PhpOption-1.1.0-1.fc18 has been pushed to the Fedora 18 testing repository.
php-PhpOption-1.1.0-1.fc18 has been pushed to the Fedora 18 stable repository.
php-PhpOption-1.1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.