Bug 906160
| Summary: | Review Request: python-feedgenerator - Standalone version of django.utils.feedgenerator | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Konstantin Ryabitsev <icon> | ||||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | echevemaster, mrunge, package-review | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-02-11 09:49:42 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 906161, 983356 | ||||||||
| Attachments: |
|
||||||||
|
Description
Konstantin Ryabitsev
2013-01-31 02:59:49 UTC
Hi Konstantin
Some initial comments:
First, the package don't build on mock, need python-setuptools as BuildRequires.
Define python_sitelib or python_sitearch macros not needed in latest releases of Fedora, only needed in el5. See [1]
Don't use python-devel as BR, use python2-devel See [2]
- the package requires pytz.
- Please take a look at ownership of files and directories.[3]
%{python_sitelib}/*
- the package is compatible with Python3 [4], please build the package with this version too. See [5]
- I understand that it is a standalone version but it would not hurt, ask for the Fedora Packaging Committee (fpc) about inclusion of this package in Fedora, See [6]
[1] http://fedoraproject.org/wiki/Packaging:Python#Macros
[2] http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
[3] https://fedoraproject.org/wiki/Packaging:UnownedDirectories
[4] http://parenchym.com/pymblog/porting-feedgenerator-to-py3k.html
[5] http://fedoraproject.org/wiki/Packaging:Python#Subpackages
[6] https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
Kind Regards
Eduardo
OK, please see: http://fedorapeople.org/~icon/f/python-feedgenerator.spec http://fedorapeople.org/~icon/f/python-feedgenerator-1.5-2.fc18.src.rpm I have also created: https://fedorahosted.org/fpc/ticket/248 Created attachment 691870 [details]
Changes between python-feedgenerator and DJango's feed generator system-wide
I take a look at the spec later I'd vote not to include this, because it mainly duplicates code from Django. Well, then we'd have to pull in 16MB of Django and all its dependencies just to satisfy a feedgenerator dependency in Pelican, which is a tiny project to create statically rendered sites. Plus then we'd need to patch Pelican just so it uses DJango's feedgenerator. Plus we'll be dropping python3 support, as Django doesn't support it. Please reconsider. Django 1.5 has Python 3 support (experimental) [1] ,obviously the problem here is that not exists yet in Fedora packaging. One might wonder why the python-feedgenerator upstream. not joined forces with Django's developers instead of duplicating efforts. [1] https://docs.djangoproject.com/en/dev/faq/install/#can-i-use-django-with-python-3 Created attachment 693154 [details] Changes between python-feedgenerator and DJango1.5's feed generator I have taken the code of Django's github repository https://github.com/django/django/tree/stable/1.5.x/django/utils Reopen this if you want to continue. |