Bug 906160 - Review Request: python-feedgenerator - Standalone version of django.utils.feedgenerator
Summary: Review Request: python-feedgenerator - Standalone version of django.utils.fee...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 906161 983356
TreeView+ depends on / blocked
 
Reported: 2013-01-31 02:59 UTC by Konstantin Ryabitsev
Modified: 2014-02-11 09:49 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-02-11 09:49:42 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Changes between python-feedgenerator and DJango's feed generator system-wide (52.31 KB, patch)
2013-02-02 04:49 UTC, Eduardo Echeverria
no flags Details | Diff
Changes between python-feedgenerator and DJango1.5's feed generator (12.88 KB, patch)
2013-02-05 05:44 UTC, Eduardo Echeverria
no flags Details | Diff

Description Konstantin Ryabitsev 2013-01-31 02:59:49 UTC
Spec URL: http://fedorapeople.org/~icon/f/python-feedgenerator.spec
SRPM URL: http://fedorapeople.org/~icon/f/python-feedgenerator-1.5-1.fc18.src.rpm
Description: Standalone version of DJango's feed generator for generating ATOM and RSS feeds.
Fedora Account System Username: icon

Comment 1 Eduardo Echeverria 2013-01-31 08:05:27 UTC
Hi Konstantin

Some initial comments: 

First, the package don't build on mock, need python-setuptools as BuildRequires.

Define python_sitelib or python_sitearch macros not needed in latest releases of Fedora, only needed in el5. See [1]

Don't use python-devel as BR, use python2-devel See [2]

- the package requires pytz.

- Please take a look at ownership of files and directories.[3]
%{python_sitelib}/*

- the package is compatible with Python3 [4], please build the package with this version too. See [5]

- I understand that it is a standalone version but it would not hurt, ask for the  Fedora Packaging Committee (fpc) about inclusion of this package in Fedora, See [6]


[1] http://fedoraproject.org/wiki/Packaging:Python#Macros
[2] http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
[3] https://fedoraproject.org/wiki/Packaging:UnownedDirectories
[4] http://parenchym.com/pymblog/porting-feedgenerator-to-py3k.html
[5] http://fedoraproject.org/wiki/Packaging:Python#Subpackages
[6] https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

Kind Regards 

Eduardo

Comment 3 Eduardo Echeverria 2013-02-02 04:49:29 UTC
Created attachment 691870 [details]
Changes between python-feedgenerator and  DJango's feed generator system-wide

Comment 4 Eduardo Echeverria 2013-02-02 05:59:23 UTC
I take a look at the spec later

Comment 5 Matthias Runge 2013-02-03 14:48:26 UTC
I'd vote not to include this, because it mainly duplicates code from Django.

Comment 6 Konstantin Ryabitsev 2013-02-04 14:46:53 UTC
Well, then we'd have to pull in 16MB of Django and all its dependencies just to satisfy a feedgenerator dependency in Pelican, which is a tiny project to create statically rendered sites. Plus then we'd need to patch Pelican just so it uses DJango's feedgenerator. Plus we'll be dropping python3 support, as Django doesn't support it.

Please reconsider.

Comment 7 Eduardo Echeverria 2013-02-05 05:14:05 UTC
Django 1.5 has Python 3 support (experimental) [1] ,obviously the problem here is that not exists yet in Fedora packaging.

One might wonder why the python-feedgenerator upstream. not joined forces with Django's developers instead of duplicating efforts.

[1] https://docs.djangoproject.com/en/dev/faq/install/#can-i-use-django-with-python-3

Comment 8 Eduardo Echeverria 2013-02-05 05:44:21 UTC
Created attachment 693154 [details]
Changes between python-feedgenerator and DJango1.5's feed generator

I have taken the code of Django's github repository
https://github.com/django/django/tree/stable/1.5.x/django/utils

Comment 9 Christopher Meng 2014-02-11 09:49:42 UTC
Reopen this if you want to continue.


Note You need to log in before you can comment on or make changes to this bug.