Bug 909060
| Summary: | Duplicate error message when adding invaild/existing ssh key or invalid/existing domain name | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | OKD | Reporter: | xjia <xjia> | ||||||
| Component: | Website | Assignee: | Fotios Lindiakos <fotios> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | libra bugs <libra-bugs> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 2.x | CC: | ccoleman, dmcphers, jkeck, pruan, xtian, yujzhang | ||||||
| Target Milestone: | --- | Keywords: | FutureFeature | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Enhancement | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-03-15 14:09:43 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
xjia
2013-02-08 06:36:53 UTC
Created attachment 694958 [details]
Duplicate error message
*** Bug 910143 has been marked as a duplicate of this bug. *** Fotios this looks like it was the result of your changes to the default error page - it's happening on numerous other pages. Need to do a sweep of the whole site. *** Bug 912192 has been marked as a duplicate of this bug. *** Submitting a PR and fork_ami for this bug. https://github.com/openshift/origin-server/pull/1544 https://ci.dev.openshift.redhat.com/jenkins/job/fork_ami/511/ Will test this issue after the fork_ami is readdy or the code is merged. (In reply to comment #5) The code is still not merged in devenv_2901. (In reply to comment #7) > (In reply to comment #5) > The code is still not merged in devenv_2901. Have you noted that fork_ami_BZ909060_514 (ami-42831f2b) is ready for testing? Tested on fork_ami_BZ909060_514, the error message when adding invalid/existing sshkey is correct now, but there is no expected error message when adding invalid/existing domain name, details see in attachment, could you please check this again? Thanks! Created attachment 706334 [details]
no error message when adding invalid/existing domain
Updated to fix these problems and another Clayton pointed out in the PR. Running a fork_ami now. Will email libra-qe when it's done. (In reply to comment #11) Tested on fork_ami_BZ909060_518, the error message of adding invalid/existing sshkey is correct now, so verify this bug, thanks. Forgot to mention, the error message of adding invalid/existing domain name is also correct now, thanks. Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/148f28f19c42401682b76ab82646ea187d53343d Bug 909060 - Corrected forms to use proper semantic_errors https://bugzilla.redhat.com/show_bug.cgi?id=909060 `semantic_errors` was pulling all errors into the `full_errors` array. When using `semantic_errors`, provide `:except => [<inputs>]` to indicate which inputs are being handled in the form/inline. All other errors will show up at the top as a "flash". |