Bug 909060 - Duplicate error message when adding invaild/existing ssh key or invalid/existing domain name
Summary: Duplicate error message when adding invaild/existing ssh key or invalid/exist...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Website
Version: 2.x
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: ---
Assignee: Fotios Lindiakos
QA Contact: libra bugs
URL:
Whiteboard:
: 910143 912192 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-08 06:36 UTC by xjia
Modified: 2015-05-15 01:18 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-15 14:09:43 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Duplicate error message (68.73 KB, image/png)
2013-02-08 06:37 UTC, xjia
no flags Details
no error message when adding invalid/existing domain (29.84 KB, image/png)
2013-03-07 03:48 UTC, Yujie Zhang
no flags Details

Description xjia 2013-02-08 06:36:53 UTC
Description of problem:
Add an invalid sshkey on "/app/account/keys". The error message of reminding user is duplicate, details see in the attachment.

Version-Release number of selected component (if applicable):
devenv-stage_284
STG(devevn-stage_283)

How reproducible:
Always

Steps to Reproduce:
1.Go to "/app/account/keys"
2.Add an invaild ssh key
3.
  
Actual results:
The error message is duplicate.Details see in attachment.

Expected results:
Only show once.

Additional info:

Comment 1 xjia 2013-02-08 06:37:17 UTC
Created attachment 694958 [details]
Duplicate error message

Comment 2 Clayton Coleman 2013-02-13 02:56:37 UTC
*** Bug 910143 has been marked as a duplicate of this bug. ***

Comment 3 Clayton Coleman 2013-03-04 15:20:29 UTC
Fotios this looks like it was the result of your changes to the default error page - it's happening on numerous other pages.  Need to do a sweep of the whole site.

Comment 4 Clayton Coleman 2013-03-04 15:21:33 UTC
*** Bug 912192 has been marked as a duplicate of this bug. ***

Comment 5 Fotios Lindiakos 2013-03-04 22:44:38 UTC
Submitting a PR and fork_ami for this bug.

https://github.com/openshift/origin-server/pull/1544
https://ci.dev.openshift.redhat.com/jenkins/job/fork_ami/511/

Comment 6 Yujie Zhang 2013-03-05 09:18:06 UTC
Will test this issue after the fork_ami is readdy or the code is merged.

Comment 7 Yujie Zhang 2013-03-06 11:19:20 UTC
(In reply to comment #5)
The code is still not merged in devenv_2901.

Comment 8 Xiaoli Tian 2013-03-06 13:47:17 UTC
(In reply to comment #7)
> (In reply to comment #5)
> The code is still not merged in devenv_2901.

Have you noted that fork_ami_BZ909060_514 (ami-42831f2b) is ready for testing?

Comment 9 Yujie Zhang 2013-03-07 03:46:15 UTC
Tested on fork_ami_BZ909060_514, the error message when adding invalid/existing sshkey is correct now, but there is no expected error message when adding invalid/existing domain name, details see in attachment, could you please check this again? Thanks!

Comment 10 Yujie Zhang 2013-03-07 03:48:11 UTC
Created attachment 706334 [details]
no error message when adding invalid/existing domain

Comment 11 Fotios Lindiakos 2013-03-07 22:52:49 UTC
Updated to fix these problems and another Clayton pointed out in the PR. Running a fork_ami now. Will email libra-qe when it's done.

Comment 12 Yujie Zhang 2013-03-08 02:33:00 UTC
(In reply to comment #11)
Tested on fork_ami_BZ909060_518, the error message of adding invalid/existing sshkey is correct now, so verify this bug, thanks.

Comment 13 Yujie Zhang 2013-03-08 02:48:47 UTC
Forgot to mention, the error message of adding invalid/existing domain name is also correct now, thanks.

Comment 14 openshift-github-bot 2013-03-08 20:57:23 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/148f28f19c42401682b76ab82646ea187d53343d
Bug 909060 - Corrected forms to use proper semantic_errors
https://bugzilla.redhat.com/show_bug.cgi?id=909060

`semantic_errors` was pulling all errors into the `full_errors` array.
When using `semantic_errors`, provide `:except => [<inputs>]` to
indicate which inputs are being handled in the form/inline.
All other errors will show up at the top as a "flash".


Note You need to log in before you can comment on or make changes to this bug.