Bug 916677

Summary:	Review Request: perl-ElasticSearch-SearchBuilder - Perlish compact query language for ElasticSearch
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-03-17 00:49:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	916679

Description Emmanuel Seyman 2013-02-28 16:13:16 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch-SearchBuilder/perl-ElasticSearch-SearchBuilder.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch-SearchBuilder/perl-ElasticSearch-SearchBuilder-0.18-1.fc18.src.rpm
Description:
The Query DSL for ElasticSearch (see Query DSL), which is used to write
queries and filters, is simple but verbose, which can make it difficult to
write and understand large queries.

Fedora Account System Username: eseyman

Comment 1 Petr Šabata 2013-03-05 16:32:36 UTC

No blockers here, approving.

However...
- perl_default_filter is unnecessary
- so is line 41
- PERL_INSTALL_ROOT could be changed to DESTDIR
- don't package dist.ini

Comment 2 Emmanuel Seyman 2013-03-05 22:43:35 UTC

Thank you for the review, Petr.

New Package SCM Request
=======================
Package Name: perl-ElasticSearch-SearchBuilder
Short Description: Perlish compact query language for ElasticSearch
Owners: eseyman
Branches: f18
InitialCC: perl-sig

Comment 3 Emmanuel Seyman 2013-03-05 22:45:39 UTC

(In reply to comment #1)
>
> - perl_default_filter is unnecessary

As it now stands, yes but I like to have it in all my perl-related spec files.

> - so is line 41

Removed.

> - PERL_INSTALL_ROOT could be changed to DESTDIR

Changed.

> - don't package dist.ini

Removed.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch-SearchBuilder/perl-ElasticSearch-SearchBuilder.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch-SearchBuilder/perl-ElasticSearch-SearchBuilder-0.18-2.fc18.src.rpm

Comment 4 Gwyn Ciesla 2013-03-06 13:38:07 UTC

Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-03-08 06:41:58 UTC

perl-ElasticSearch-SearchBuilder-0.18-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-ElasticSearch-SearchBuilder-0.18-2.fc18

Comment 6 Fedora Update System 2013-03-08 23:50:58 UTC

perl-ElasticSearch-SearchBuilder-0.18-2.fc18 has been pushed to the Fedora 18 testing repository.

Comment 7 Fedora Update System 2013-03-17 00:49:23 UTC

perl-ElasticSearch-SearchBuilder-0.18-2.fc18 has been pushed to the Fedora 18 stable repository.