Spec URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch/perl-ElasticSearch.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch/perl-ElasticSearch-0.64-1.fc18.src.rpm Description: ElasticSearch is an Open Source (Apache 2 license), distributed, RESTful Search Engine based on Lucene, and built for the cloud, with a JSON API. This perl module is a thin API which makes it easy to communicate with an ElasticSearch cluster. Fedora Account System Username: eseyman
Missing BRs: perl(constant) from lib/ElasticSearch/RequestParser.pm:10,19 perl(lib) from t/00-request.t:5 perl(Data::Dumper) from lib/ElasticSearch/Error.pm:30 perl(Encode) from lib/ElasticSearch/Transport.pm:11 and more perl(Exporter) from lib/ElasticSearch/Util.pm:10 perl(File::Path) from lib/ElasticSearch/TestServer.pm:14 perl(File::Temp) from lib/ElasticSearch/TestServer.pm:11 perl(IO::Handle) from lib/ElasticSearch/Transport.pm:14 perl(IO::Socket) from lib/ElasticSearch/TestServer.pm:10 perl(JSON::XS) and perl(URI::Escape::XS) are not required for build, just recommended for runtime. You can drop those deps. perl(Task::Weaken) is not used anywhere. You can drop this dep too. Line 61 is unnecessary. Cosmetics: Since all the autoprovided modules are versioned, adding %{version} to your explicit Provides would be great. No other issues.
(In reply to comment #1) > Missing BRs: > perl(constant) from lib/ElasticSearch/RequestParser.pm:10,19 > perl(lib) from t/00-request.t:5 > perl(Data::Dumper) from lib/ElasticSearch/Error.pm:30 > perl(Encode) from lib/ElasticSearch/Transport.pm:11 and more > perl(Exporter) from lib/ElasticSearch/Util.pm:10 > perl(File::Path) from lib/ElasticSearch/TestServer.pm:14 > perl(File::Temp) from lib/ElasticSearch/TestServer.pm:11 > perl(IO::Handle) from lib/ElasticSearch/Transport.pm:14 > perl(IO::Socket) from lib/ElasticSearch/TestServer.pm:10 Added. > perl(JSON::XS) and perl(URI::Escape::XS) are not required for build, just > recommended for runtime. You can drop those deps. > perl(Task::Weaken) is not used anywhere. You can drop this dep too. Removed > Line 61 is unnecessary. Removed > Cosmetics: Since all the autoprovided modules are versioned, adding > %{version} to your explicit Provides would be great. You're right. Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch/perl-ElasticSearch.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch/perl-ElasticSearch-0.64-2.fc18.src.rpm
Ok, approving. (...) %changelog +* Sun Apr 14 2013 Emmanuel Seyman <emmanuel> - 0.64-2 +Take into account review comments (#916679) + Looks a bit unusual without the preceding '- ', however I'm not sure if it's required...
(In reply to comment #3) > > Looks a bit unusual without the preceding '- ', however I'm not sure if it's > required... It is. Fixed. Thanks for the review, Petr. New Package SCM Request ======================= Package Name: perl-ElasticSearch Short Description: API for communicating with ElasticSearch Owners: eseyman Branches: f18 f19 InitialCC: perl-sig
Git done (by process-git-requests).
perl-ElasticSearch-0.64-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-ElasticSearch-0.64-2.fc18
perl-ElasticSearch-0.64-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-ElasticSearch-0.64-2.fc19
perl-ElasticSearch-0.64-2.fc19 has been pushed to the Fedora 19 testing repository.
perl-ElasticSearch-0.64-2.fc19 has been pushed to the Fedora 19 stable repository.