Spec URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch-SearchBuilder/perl-ElasticSearch-SearchBuilder.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch-SearchBuilder/perl-ElasticSearch-SearchBuilder-0.18-1.fc18.src.rpm Description: The Query DSL for ElasticSearch (see Query DSL), which is used to write queries and filters, is simple but verbose, which can make it difficult to write and understand large queries. Fedora Account System Username: eseyman
No blockers here, approving. However... - perl_default_filter is unnecessary - so is line 41 - PERL_INSTALL_ROOT could be changed to DESTDIR - don't package dist.ini
Thank you for the review, Petr. New Package SCM Request ======================= Package Name: perl-ElasticSearch-SearchBuilder Short Description: Perlish compact query language for ElasticSearch Owners: eseyman Branches: f18 InitialCC: perl-sig
(In reply to comment #1) > > - perl_default_filter is unnecessary As it now stands, yes but I like to have it in all my perl-related spec files. > - so is line 41 Removed. > - PERL_INSTALL_ROOT could be changed to DESTDIR Changed. > - don't package dist.ini Removed. Spec URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch-SearchBuilder/perl-ElasticSearch-SearchBuilder.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-ElasticSearch-SearchBuilder/perl-ElasticSearch-SearchBuilder-0.18-2.fc18.src.rpm
Git done (by process-git-requests).
perl-ElasticSearch-SearchBuilder-0.18-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-ElasticSearch-SearchBuilder-0.18-2.fc18
perl-ElasticSearch-SearchBuilder-0.18-2.fc18 has been pushed to the Fedora 18 testing repository.
perl-ElasticSearch-SearchBuilder-0.18-2.fc18 has been pushed to the Fedora 18 stable repository.