Bug 949038 (horde)
| Summary: | Review Request: php-horde-horde - Horde Application Framework | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | amessina, greg, package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
kevin: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-horde-horde-5.1.6-3.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-04-29 05:12:18 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 874677, 908329, 909662, 1051372 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Remi Collet
2013-04-05 16:57:23 UTC
The test to obsoletes/conflicts current package is temporary. Will have to be fixed when all the horde packages will be ready and the old ones could be removed from repository. The conflicts allow to keep both in the repository for some time (at least in stable release, so F18, and perhaps F19, to be discussed) Update to 5.0.5 Spec: https://github.com/remicollet/remirepo/blob/8e963fbb8b3fb7321d778668d080f77c27b312aa/php/horde/php-horde-horde/php-horde-horde.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-horde-5.0.5-1.remi.src.rpm Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-horde/php-horde-horde.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-horde-5.1.5-1.remi.src.rpm Spec: https://raw.github.com/remicollet/remirepo/eed38ae273b2d23fe01ead842ad6252f9add978f/php/horde/php-horde-horde/php-horde-horde.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-horde-5.1.6-1.remi.src.rpm Looks like there is nothing blocking this review now. Great work (and persistance / patience) Remi! I'll be happy to test Horde when this last package is in the testing repo. Created attachment 885791 [details]
phpcompatinfo.log
phpcompatinfo version 2.26.0
Created attachment 885792 [details]
fedora-review.txt
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 949038
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
As usual, just clean these up after initial import.
[x]: Requires correct, justified where necessary.
From package.xml:
php-filter
From phpcompatinfo:
php-json
Comment:
# Optional but implicitly required
# Horde_Db, Horde_Feed, Horde_Oauth, Horde_SyncMl
but Horde_Feed is listed as required
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
php-horde-horde.noarch: E: incorrect-fsf-address /usr/share/doc/pear/horde/COPYING
I am leaving it up to you to determine the "correctness" of the other rpmlint warnings/errors.
Thanks !! https://github.com/remicollet/remirepo/commit/8b9a404eb17aca5fe3c98ccb6f44c6eedcc65e85 New Package SCM Request ======================= Package Name: php-horde-horde Short Description: Horde Application Framework Owners: remi Branches: f20 el6 epel7 InitialCC: Git done (by process-git-requests). Build in rawhide + epel7 Will push all the horde applications at the same time (when all will be reviewed) in f20 / epel6 php-horde-horde-5.1.6-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-horde-5.1.6-3.el6 php-horde-horde-5.1.6-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-horde-horde-5.1.6-3.fc20 php-horde-horde-5.1.6-3.fc20 has been pushed to the Fedora 20 stable repository. php-horde-horde-5.1.6-3.el6 has been pushed to the Fedora EPEL 6 stable repository. |