Bug 949038 (horde) - Review Request: php-horde-horde - Horde Application Framework
Summary: Review Request: php-horde-horde - Horde Application Framework
Alias: horde
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
Depends On: Horde_Rpc Horde_Core Horde_View Horde_Form
TreeView+ depends on / blocked
Reported: 2013-04-05 16:57 UTC by Remi Collet
Modified: 2014-06-11 23:33 UTC (History)
4 users (show)

Fixed In Version: php-horde-horde-5.1.6-3.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-04-29 05:12:18 UTC
Type: ---
shawn: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)
phpcompatinfo.log (38.64 KB, text/x-log)
2014-04-12 21:42 UTC, Shawn Iwinski
no flags Details
fedora-review.txt (13.96 KB, text/plain)
2014-04-12 21:42 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2013-04-05 16:57:23 UTC
Spec URL: https://raw.github.com/remicollet/remirepo/5c6834329bf3993a596ceb09378d57ca824607ab/php/horde/php-horde-horde/php-horde-horde.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-horde-5.0.4-2.remi.src.rpm
The Horde Application Framework is a flexible, modular, general-purpose web
application framework written in PHP. It provides an extensive array of
components that are targeted at the common problems and tasks involved in
developing modern web applications. It is the basis for a large number of
production-level web applications, notably the Horde Groupware suites. For
more information on Horde or the Horde Groupware suites, visit

Fedora Account System Username: remi

Comment 1 Remi Collet 2013-04-05 17:26:38 UTC
The test to obsoletes/conflicts current package is temporary.

Will have to be fixed when all the horde packages will be ready and the old ones could be removed from repository.

The conflicts allow to keep both in the repository for some time (at least in stable release, so F18, and perhaps F19, to be discussed)

Comment 5 Greg Swallow 2014-03-31 18:29:08 UTC
Looks like there is nothing blocking this review now.  Great work (and persistance / patience) Remi!  I'll be happy to test Horde when this last package is in the testing repo.

Comment 6 Shawn Iwinski 2014-04-12 21:42:28 UTC
Created attachment 885791 [details]

phpcompatinfo version 2.26.0

Comment 7 Shawn Iwinski 2014-04-12 21:42:59 UTC
Created attachment 885792 [details]

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 949038
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby

Comment 8 Shawn Iwinski 2014-04-12 21:45:48 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     Note: %clean present but not required

As usual, just clean these up after initial import.

[x]: Requires correct, justified where necessary.

     From package.xml:
     From phpcompatinfo:
         # Optional but implicitly required
         #               Horde_Db, Horde_Feed, Horde_Oauth, Horde_SyncMl
     but Horde_Feed is listed as required

[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
     php-horde-horde.noarch: E: incorrect-fsf-address /usr/share/doc/pear/horde/COPYING

     I am leaving it up to you to determine the "correctness" of the other rpmlint warnings/errors.

Comment 9 Remi Collet 2014-04-13 07:28:54 UTC
Thanks !!


New Package SCM Request
Package Name: php-horde-horde
Short Description: Horde Application Framework
Owners: remi
Branches: f20 el6 epel7

Comment 10 Kevin Fenzi 2014-04-13 20:33:43 UTC
Git done (by process-git-requests).

Comment 11 Remi Collet 2014-04-29 05:12:18 UTC
Build in rawhide + epel7

Will push all the horde applications at the same time (when all will be reviewed) in f20 / epel6

Comment 12 Fedora Update System 2014-05-19 15:08:07 UTC
php-horde-horde-5.1.6-3.el6 has been submitted as an update for Fedora EPEL 6.

Comment 13 Fedora Update System 2014-05-19 15:08:16 UTC
php-horde-horde-5.1.6-3.fc20 has been submitted as an update for Fedora 20.

Comment 14 Fedora Update System 2014-06-05 04:21:36 UTC
php-horde-horde-5.1.6-3.fc20 has been pushed to the Fedora 20 stable repository.

Comment 15 Fedora Update System 2014-06-11 23:33:52 UTC
php-horde-horde-5.1.6-3.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.