Bug 949311
| Summary: | Review Request: python-workerpool - Multithreaded job distribution module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-04 21:03:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 949371 | ||
|
Description
Orion Poplawski
2013-04-07 16:42:14 UTC
For 0.9.2-1:
* License tag
- The license is MIT, not BSD.
* Build failure
- Does not build on either F-20 or F-19:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5325042
http://koji.fedoraproject.org/koji/taskinfo?taskID=5325043
Seems python-nose, python3-nose are needed for BR.
However even with these, %check still "really" fails
randomly:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5325084
* $RPM_BUILD_ROOT v.s. %buildroot
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- Please choose one style and aviod using both style.
* No longer needed stuff
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag
- Cleaning up %buildroot at the beginning of %install is
no longer needed (on Fedora).
* Suggestions
* Same summary / description for python2 and python3
version package
- At least it is preferable to distinguish python2 and
python3 version of the packages in %description.
* Needed documentations
- Is "test" directory needed for "documentation"?
By the way I appreciate it if you would review one of my review requests (bug 958149 ) I've filed this issue about the test failure: https://github.com/shazow/workerpool/issues/3 Looks like the tests assume a certain ordering of operations, but it does not appear that workerpool guarantees that ordering. Hopefully I'll get a response soon. I've fixed the other stuff here: http://www.cora.nwra.com/~orion/fedora/python-workerpool.spec http://www.cora.nwra.com/~orion/fedora/python-workerpool-0.9.2-1.fc18.src.rpm * Thu May 2 2013 Orion Poplawski <orion.com> - 0.9.2-2 - Change license to MIT - Fix macro consistency - Add BR python-nose Well, if you are okay I will also wait for upstream response about test failure. http://www.cora.nwra.com/~orion/fedora/python-workerpool.spec http://www.cora.nwra.com/~orion/fedora/python-workerpool-0.9.2-3.fc18.src.rpm * Thu May 2 2013 Orion Poplawski <orion.com> - 0.9.2-3 - Add patch to fix tests Patch submitted and accepted upstream. Well, * So would you tell me if "test" directory is really needed (for %doc)? (not a blocker, however I want to see your opinition). Note that currently test_workerpool.py.test is also packaged, which at least should be removed. * After reading bug 957568 comment 2 , I now thinks that workerpool.egg-info in tarball should be removed at %prep to ensure that egg-info is really rebuilt, however for now I leave it to you. http://www.cora.nwra.com/~orion/fedora/python-workerpool-0.9.2-4.fc18.src.rpm * Fri May 3 2013 Orion Poplawski <orion.com> - 0.9.2-4 - Don't ship tests - Remove shipped egg-info Yeah, probably not worth shipping these tests. Okay. ------------------------------------------------------ This package (python-workerpool) is APPROVED by mtasaka ------------------------------------------------------ New Package SCM Request ======================= Package Name: python-workerpool Short Description: Multithreaded job distribution module Owners: orion Branches: f19 f18 el6 InitialCC: Git done (by process-git-requests). Checked in and built. Thanks all! |