Bug 961493
| Summary: | ptpd configuration file should be updated | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lukas Marek <lukas.marek> |
| Component: | ptpd | Assignee: | Jon Kent <jon.kent> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 18 | CC: | jon.kent |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 2.2.0-4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-20 09:23:38 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lukas Marek
2013-05-09 17:48:32 UTC
Hi, Thanks for reporting this. I've modified the name of sysconfig/ptpd to sysconfig/ptpd2 The systemd has been modified to use $PTPDARGS I've also expanded the examples within the sysconfig/ptpd2 file. These where only ever meant as examples as the configuration of ptpd2 should only be decided upon though testing. The examples now read: # Example client (slave) arguments #PTPDARGS="-n Example -D -b eth0 -L -D -g -i 1 -w 10000 -R /var/log/ptpd2_sync.log -f /var/log/ptpd2.log" # Example server arguments #PTPDARGS="-n Example -D -b eth0 -L -D -i 1 -s 1 -G -w 10000 -R /var/log/ptpd2_sync.log -f /var/log/ptpd.log" But these should only be used once testing is completed, especially the one-way stiffness setting (-w) I'll place the new build request into koji today on the back of the other bugzilla report on ptpd2 - 961481. Regards, Jon Thanks for so prompt fix. I will be happy to test it once it reaches testing repository. Hi, For tracking info. koji build completed successfully: http://koji.fedoraproject.org/koji/buildinfo?buildID=418290 To be promoted to bodhi Regards, Jon (In reply to comment #2) > Thanks for so prompt fix. I will be happy to test it once it reaches testing > repository. Thanks, I'll post here once it has passed Bodhi staging. Its passed by own testing so this should be a good build. FYI found another bug in the systemd service script which has now be resolved. Regards, Jon ptpd-2.2.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ptpd-2.2.0-2.fc18 ptpd-2.2.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ptpd-2.2.0-2.fc19 Package ptpd-2.2.0-2.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ptpd-2.2.0-2.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-7982/ptpd-2.2.0-2.fc18 then log in and leave karma (feedback). I've just looked at the updated package and I wasn't able to spot any changes you have mentioned. Build seems to me very similar to the original ptpd-2.2.0-1.fc18 version. Hi, Oh, that's a bit odd. I'll take a look this evening to see what has gone wrong here. Sorry about that. Regards, Jon Hi, Problem found, I forgot to apply patch to the fc18 branch, only applied it to master :-x Currently building this. Sorry about that, Regards, Jon ptpd-2.2.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ptpd-2.2.0-3.fc18 ptpd-2.2.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ptpd-2.2.0-3.fc19 *** Bug 961481 has been marked as a duplicate of this bug. *** hi, I believe that this is ready for testing. Not sure why this hasn't been automatically updated with the status. Regards, Jon Everything I've reported is fixed, but I've discovered other small issues. When I upgrade the package, my configuration gets overwritten. Maybe the config file needs to be marked? https://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch09s05s03.html I can crate another bug report if you prefer. Lukas Hi, that for looking at that. I think we can keep the last issue here as its pretty easy to resolve: %config(noreplace) /etc/sysconfig.d/ptpd2 in the spec file. So I'll update that tonight. Regards, Jon Hi, maybe this is problem on my side. I have no /etc/sysconfig.d/ directory so I'm placing all the configuration directly to the /etc/sysconfig/ptpd2. Overall I like the /etc/*.d/ configs but is it possible to do it for ptpd2 like that? Lukas Hi, no not problem you end, typo @ mine :) It is /etc/sysconfig. Update on its way. Works like this (standard mechanism): If file exists, create [filename].rpmnew which contains version from updated/installed rpm. Else, install as expected. yum will tell you if is creates an rpmnew file. When rpm removed, file saved as [filename].rpmsave Regards, Jon ptpd-2.2.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ptpd-2.2.0-4.fc18 ptpd-2.2.0-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ptpd-2.2.0-4.fc19 Hi Jon, I've updated to ptpd-2.2.0-4.fc18. My config is unharmed. I was checking and there is no /etc/sysconfig/ptpd2.rpmnew but this is ok for me. Lukas Hi Lukas, Great news. OK I'll close this down. Thanks for your help. Regards, Jon ptpd-2.2.0-4.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. ptpd-2.2.0-4.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |