Bug 961493 - ptpd configuration file should be updated
Summary: ptpd configuration file should be updated
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: ptpd
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Jon Kent
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 961481 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-09 17:48 UTC by Lukas Marek
Modified: 2013-05-28 02:19 UTC (History)
1 user (show)

Fixed In Version: 2.2.0-4
Clone Of:
Environment:
Last Closed: 2013-05-20 09:23:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lukas Marek 2013-05-09 17:48:32 UTC
Current ptpd configuration file (/etc/sysconfig/ptpd) is not very usable.
After number) is a line from the config file and under a), b),... are problems.

1) # See man ptpd for arguments and /usr/share/doc/ptpd

 a) It is not ptpd but ptpd2.

2) #PTPDARGS="-n Example -D -b eth0 -f /var/log/ptpd.log"

 a) PTPDARGS are not specified in systemd service file. There it is called OPTIONS.
 b) "-n" should be numeric value.
 c) I was unable to start the client using the systemd service file without "-c" option (maybe it should be directly in the systemd file?).
 d) There is a missing mode for client which is now "-g".

3) #PTPDARGS="-n Example -D -b eth0 -s 1 -i NTP -t -f /var/log/ptpd.log"

 a), b) and c) from 2) are valid here.
 d) Server should have either "-G" or "-W" switch.

Comment 1 Jon Kent 2013-05-10 08:48:54 UTC
Hi,

Thanks for reporting this. I've modified the name of sysconfig/ptpd to sysconfig/ptpd2

The systemd has been modified to use $PTPDARGS

I've also expanded the examples within the sysconfig/ptpd2 file.  These where only ever meant as examples as the configuration of ptpd2 should only be decided upon though testing.  The examples now read:

# Example client (slave) arguments
#PTPDARGS="-n Example -D -b eth0 -L -D -g -i 1 -w 10000 -R /var/log/ptpd2_sync.log -f /var/log/ptpd2.log"

# Example server arguments
#PTPDARGS="-n Example -D -b eth0 -L -D -i 1 -s 1 -G -w 10000 -R /var/log/ptpd2_sync.log -f /var/log/ptpd.log"

But these should only be used once testing is completed, especially the one-way stiffness setting (-w)

I'll place the new build request into koji today on the back of the other bugzilla report on ptpd2 - 961481.

Regards,
Jon

Comment 2 Lukas Marek 2013-05-10 11:06:04 UTC
Thanks for so prompt fix. I will be happy to test it once it reaches testing repository.

Comment 3 Jon Kent 2013-05-11 21:59:02 UTC
Hi,

For tracking info.

koji build completed successfully:

http://koji.fedoraproject.org/koji/buildinfo?buildID=418290

To be promoted to bodhi


Regards,
Jon

Comment 4 Jon Kent 2013-05-11 22:00:41 UTC
(In reply to comment #2)
> Thanks for so prompt fix. I will be happy to test it once it reaches testing
> repository.

Thanks, I'll post here once it has passed Bodhi staging.

Its passed by own testing so this should be a good build.  FYI found another bug in the systemd service script which has now be resolved.

Regards,
Jon

Comment 5 Fedora Update System 2013-05-11 22:16:53 UTC
ptpd-2.2.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ptpd-2.2.0-2.fc18

Comment 6 Fedora Update System 2013-05-11 22:18:43 UTC
ptpd-2.2.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ptpd-2.2.0-2.fc19

Comment 7 Fedora Update System 2013-05-13 00:26:11 UTC
Package ptpd-2.2.0-2.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ptpd-2.2.0-2.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-7982/ptpd-2.2.0-2.fc18
then log in and leave karma (feedback).

Comment 8 Lukas Marek 2013-05-14 09:41:02 UTC
I've just looked at the updated package and I wasn't able to spot any changes you have mentioned. Build seems to me very similar to the original ptpd-2.2.0-1.fc18 version.

Comment 9 Jon Kent 2013-05-14 09:48:13 UTC
Hi,

Oh, that's a bit odd.  I'll take a look this evening to see what has gone wrong here.

Sorry about that.

Regards,
Jon

Comment 10 Jon Kent 2013-05-14 19:02:34 UTC
Hi,

Problem found, I forgot to apply patch to the fc18 branch, only applied it to master :-x

Currently building this.

Sorry about that,

Regards,
Jon

Comment 11 Fedora Update System 2013-05-14 19:18:48 UTC
ptpd-2.2.0-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ptpd-2.2.0-3.fc18

Comment 12 Fedora Update System 2013-05-14 20:03:57 UTC
ptpd-2.2.0-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ptpd-2.2.0-3.fc19

Comment 13 Jon Kent 2013-05-14 20:28:22 UTC
*** Bug 961481 has been marked as a duplicate of this bug. ***

Comment 14 Jon Kent 2013-05-16 14:12:17 UTC
hi,

I believe that this is ready for testing.  Not sure why this hasn't been automatically updated with the status.

Regards,
Jon

Comment 15 Lukas Marek 2013-05-17 11:49:46 UTC
Everything I've reported is fixed, but I've discovered other small issues. When I upgrade the package, my configuration gets overwritten.

Maybe the config file needs to be marked?

https://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch09s05s03.html

I can crate another bug report if you prefer.

Lukas

Comment 16 Jon Kent 2013-05-17 12:28:05 UTC
Hi,

that for looking at that.  I think we can keep the last issue here as its pretty easy to resolve:

%config(noreplace) /etc/sysconfig.d/ptpd2

in the spec file.  So I'll update that tonight.

Regards,
Jon

Comment 17 Lukas Marek 2013-05-17 12:59:09 UTC
Hi,

maybe this is problem on my side. I have no /etc/sysconfig.d/ directory so I'm placing all the configuration directly to the /etc/sysconfig/ptpd2. Overall I like the /etc/*.d/ configs but is it possible to do it for ptpd2 like that?

Lukas

Comment 18 Jon Kent 2013-05-18 17:19:50 UTC
Hi,

no not problem you end, typo @ mine :)

It is /etc/sysconfig.

Update on its way.  Works like this (standard mechanism):

If file exists, create [filename].rpmnew which contains version from updated/installed rpm.  Else, install as expected.  yum will tell you if is creates an rpmnew file.  When rpm removed, file saved as [filename].rpmsave

Regards,
Jon

Comment 19 Fedora Update System 2013-05-18 17:24:33 UTC
ptpd-2.2.0-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ptpd-2.2.0-4.fc18

Comment 20 Fedora Update System 2013-05-18 17:33:21 UTC
ptpd-2.2.0-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ptpd-2.2.0-4.fc19

Comment 21 Lukas Marek 2013-05-19 20:46:57 UTC
Hi Jon,

I've updated to ptpd-2.2.0-4.fc18. My config is unharmed. I was checking and there is no /etc/sysconfig/ptpd2.rpmnew but this is ok for me.

Lukas

Comment 22 Jon Kent 2013-05-20 09:23:38 UTC
Hi Lukas,

Great news.  OK I'll close this down.

Thanks for your help.

Regards,
Jon

Comment 23 Fedora Update System 2013-05-27 00:31:53 UTC
ptpd-2.2.0-4.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2013-05-28 02:19:38 UTC
ptpd-2.2.0-4.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.