Bug 979668
| Summary: | Review Request: perl-HTML-Entities-Interpolate - Call HTML::Entities::encode_entities via a hash within a string | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-HTML-Entities-Interpolate-1.05-1.fc18 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-02 03:45:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 979667 | ||
| Bug Blocks: | 987717 | ||
|
Description
Christopher Meng
2013-06-29 09:21:57 UTC
Sorry for the wrong description. Please view the SRPM. source srpm not found (In reply to Parag AN(पराग) from comment #2) > source srpm not found Please check again, sorry. NEW SPEC URL: http://cicku.me/perl-HTML-Entities-Interpolate.spec NEW SRPM URL: http://cicku.me/perl-HTML-Entities-Interpolate-1.04-1.fc20.src.rpm Review: + mock build is successful for f20 + rpmlint output on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) srpm trball : efc22c4aa1fbe26112a53e4e637c7632b48ea429f2648cdb3207fc003e7540f9 upstream tarball : efc22c4aa1fbe26112a53e4e637c7632b48ea429f2648cdb3207fc003e7540f9 - License "GPLv2+ or Artistic" is NOT valid. I see its Artistic 1.0 + rest follows packaging guidelines + make test is successful with output All tests successful. Files=2, Tests=2, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.06 cusr 0.01 csys = 0.10 CPU) + Package perl-HTML-Entities-Interpolate-1.04-1.fc20 Provides: perl(HTML::Entities::Interpolate) = 1.04 perl-HTML-Entities-Interpolate = 1.04-1.fc20 Requires: perl(HTML::Entities) perl(Tie::Function) perl(warnings) Suggestions: 1) Get the license clarified with upstream. The author just changed the license, as a result my waiting is over, I will update soon. NEW SPEC URL: http://cicku.me/perl-HTML-Entities-Interpolate.spec NEW SRPM URL: http://cicku.me/perl-HTML-Entities-Interpolate-1.05-1.fc20.src.rpm Review: + mock build is successful for f20 + rpmlint output on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) srpm tarball : f5c0199c72acb65f7ea158698fa8dc13c1cd4d64b8ba657a2e18e93d859b1f81 upstream tarball : f5c0199c72acb65f7ea158698fa8dc13c1cd4d64b8ba657a2e18e93d859b1f81 + License "Artistic 2.0" is valid and included in source files. + rest follows packaging guidelines + make test is successful with output All tests successful. Files=2, Tests=2, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.06 cusr 0.01 csys = 0.10 CPU) + Package perl-HTML-Entities-Interpolate-1.05-1.fc20 Provides: perl(HTML::Entities::Interpolate) = 1.05 perl-HTML-Entities-Interpolate = 1.05-1.fc20 Requires: perl(HTML::Entities) perl(Tie::Function) perl(warnings) APPROVED. New Package SCM Request ======================= Package Name: perl-HTML-Entities-Interpolate Short Description: Call HTML::Entities::encode_entities via a hash within a string Owners: cicku Branches: f18 f19 InitialCC: Git done (by process-git-requests). Its been almost 2 weeks since SCM request has been done and this review is not closed. I can see this package is already available on koji. perl-HTML-Entities-Interpolate-1.05-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-HTML-Entities-Interpolate-1.05-1.fc18 Yeah yeah yeah just built it 30 mins ago. Busy these days and I still have 2 perl packages have no assignee. perl-HTML-Entities-Interpolate-1.05-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-HTML-Entities-Interpolate-1.05-1.fc19 perl-HTML-Entities-Interpolate-1.05-1.fc18 has been pushed to the Fedora 18 testing repository. perl-HTML-Entities-Interpolate-1.05-1.fc19 has been pushed to the Fedora 19 stable repository. perl-HTML-Entities-Interpolate-1.05-1.fc18 has been pushed to the Fedora 18 stable repository. |