Bug 979668 - Review Request: perl-HTML-Entities-Interpolate - Call HTML::Entities::encode_entities via a hash within a string
Review Request: perl-HTML-Entities-Interpolate - Call HTML::Entities::encode_...
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On: 979667
Blocks: 987717
  Show dependency treegraph
 
Reported: 2013-06-29 05:21 EDT by Christopher Meng
Modified: 2013-08-01 23:53 EDT (History)
3 users (show)

See Also:
Fixed In Version: perl-HTML-Entities-Interpolate-1.05-1.fc18
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-08-01 23:45:27 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Christopher Meng 2013-06-29 05:21:57 EDT
Spec URL: http://cicku.me/perl-HTML-Entities-Interpolate.spec
SRPM URL: http://cicku.me/perl-HTML-Entities-Interpolate-1.04-1.fc20.srpm
Description: Given a file from the BackPAN, this module will let you find out what versions of what modules it contains, the distribution name and version.
Fedora Account System Username: cicku
Comment 1 Christopher Meng 2013-06-29 05:29:00 EDT
Sorry for the wrong description.

Please view the SRPM.
Comment 2 Parag AN(पराग) 2013-07-03 07:04:22 EDT
source srpm not found
Comment 3 Christopher Meng 2013-07-03 07:58:41 EDT
(In reply to Parag AN(पराग) from comment #2)
> source srpm not found

Please check again, sorry.

NEW SPEC URL: http://cicku.me/perl-HTML-Entities-Interpolate.spec
NEW SRPM URL: http://cicku.me/perl-HTML-Entities-Interpolate-1.04-1.fc20.src.rpm
Comment 4 Parag AN(पराग) 2013-07-03 08:59:09 EDT
Review:

+ mock build is successful for f20

+ rpmlint output on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as (sha256sum)
srpm trball : efc22c4aa1fbe26112a53e4e637c7632b48ea429f2648cdb3207fc003e7540f9
upstream tarball : efc22c4aa1fbe26112a53e4e637c7632b48ea429f2648cdb3207fc003e7540f9

- License "GPLv2+ or Artistic" is NOT valid. I see its Artistic 1.0 

+ rest follows packaging guidelines

+ make test is successful with output
All tests successful.
Files=2, Tests=2,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.06 cusr  0.01 csys =  0.10 CPU)

+ Package perl-HTML-Entities-Interpolate-1.04-1.fc20
Provides: perl(HTML::Entities::Interpolate) = 1.04 perl-HTML-Entities-Interpolate = 1.04-1.fc20

Requires: perl(HTML::Entities) perl(Tie::Function) perl(warnings)

Suggestions:
1) Get the license clarified with upstream.
Comment 5 Christopher Meng 2013-07-11 01:38:22 EDT
The author just changed the license, as a result my waiting is over, I will update soon.
Comment 7 Parag AN(पराग) 2013-07-11 04:47:26 EDT
Review:

+ mock build is successful for f20

+ rpmlint output on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball     : f5c0199c72acb65f7ea158698fa8dc13c1cd4d64b8ba657a2e18e93d859b1f81
upstream tarball : f5c0199c72acb65f7ea158698fa8dc13c1cd4d64b8ba657a2e18e93d859b1f81

+ License "Artistic 2.0" is valid and included in source files.

+ rest follows packaging guidelines

+ make test is successful with output
All tests successful.
Files=2, Tests=2,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.06 cusr  0.01 csys =  0.10 CPU)

+ Package perl-HTML-Entities-Interpolate-1.05-1.fc20
Provides: perl(HTML::Entities::Interpolate) = 1.05 perl-HTML-Entities-Interpolate = 1.05-1.fc20
Requires: perl(HTML::Entities) perl(Tie::Function) perl(warnings)

APPROVED.
Comment 8 Christopher Meng 2013-07-11 04:55:38 EDT
New Package SCM Request
=======================
Package Name: perl-HTML-Entities-Interpolate
Short Description: Call HTML::Entities::encode_entities via a hash within a string
Owners: cicku
Branches: f18 f19
InitialCC:
Comment 9 Gwyn Ciesla 2013-07-11 06:49:36 EDT
Git done (by process-git-requests).
Comment 10 Parag AN(पराग) 2013-07-22 00:20:51 EDT
Its been almost 2 weeks since SCM request has been done and this review is not closed. I can see this package is already available on koji.
Comment 11 Fedora Update System 2013-07-22 00:22:23 EDT
perl-HTML-Entities-Interpolate-1.05-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-HTML-Entities-Interpolate-1.05-1.fc18
Comment 12 Christopher Meng 2013-07-22 00:22:48 EDT
Yeah yeah yeah just built it 30 mins ago.

Busy these days and I still have 2 perl packages have no assignee.
Comment 13 Fedora Update System 2013-07-22 00:23:31 EDT
perl-HTML-Entities-Interpolate-1.05-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-HTML-Entities-Interpolate-1.05-1.fc19
Comment 14 Fedora Update System 2013-07-22 21:04:01 EDT
perl-HTML-Entities-Interpolate-1.05-1.fc18 has been pushed to the Fedora 18 testing repository.
Comment 15 Fedora Update System 2013-08-01 23:45:27 EDT
perl-HTML-Entities-Interpolate-1.05-1.fc19 has been pushed to the Fedora 19 stable repository.
Comment 16 Fedora Update System 2013-08-01 23:53:59 EDT
perl-HTML-Entities-Interpolate-1.05-1.fc18 has been pushed to the Fedora 18 stable repository.

Note You need to log in before you can comment on or make changes to this bug.