Bug 979801

Summary: Provide an extra Package for SFML-2.0
Product: [Fedora] Fedora Reporter: Marcel Hellwig <redhat>
Component: SFMLAssignee: Julian Sikorski <belegdol>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: belegdol, hdegoede, redhat
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: compat-SFML16-1.6-1.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-04 17:46:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marcel Hellwig 2013-06-30 18:10:56 UTC
Description of problem:
Some programms need the "old" SFML-1.6 libraries. So make a new SFML-2.0 package instead of overwriting the existing one (an example is vbam-gtk).

Steps to Reproduce:
1. yum upgrade (to SFML-2.0)
2. yum install vbam-gtk (rawhide must be enabled)
3. see an error

Comment 1 Marcel Hellwig 2013-06-30 18:19:07 UTC
*** Bug 979802 has been marked as a duplicate of this bug. ***

Comment 2 Julian Sikorski 2013-07-08 04:49:08 UTC
SFML-2.0 is parrallel-installable with 1.6 now. Hans was working on compat-SFML16. Hans, would you be able to provide an update on this?

Comment 3 Hans de Goede 2013-07-12 09:50:44 UTC
Hi,

(In reply to Julian Sikorski from comment #2)
> SFML-2.0 is parrallel-installable with 1.6 now. Hans was working on
> compat-SFML16. Hans, would you be able to provide an update on this?

Yes, long story short: I got side tracked with other stuff. But I've just picked up the track again and completed my compat-SFML16 package, see bug 983922 for the review request, please review.

Once compat-SFML16 has been reviewed I'll build it for rawhide and F-19, while also upgrading the F-19 SFML packages to SFML-2.0 (merging it with the fedpkg master branch). Then I'll push both SFML-2.0 and compat-SFML16 as F-19 updates in one update.

So if I can get a review of compat-SFML16 (easy, just a pkg rename of the existing F-19 package), we can have this resolved pretty quickly.

Regards,

Hans

Comment 4 Fedora Update System 2013-07-18 10:47:11 UTC
compat-SFML16-1.6-1.fc19,SFML-2.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/compat-SFML16-1.6-1.fc19,SFML-2.0-2.fc19

Comment 5 Fedora Update System 2013-07-20 09:39:27 UTC
Package compat-SFML16-1.6-1.fc19, SFML-2.0-2.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing compat-SFML16-1.6-1.fc19 SFML-2.0-2.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-13257/compat-SFML16-1.6-1.fc19,SFML-2.0-2.fc19
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2013-07-28 01:05:36 UTC
compat-SFML16-1.6-1.fc19, SFML-2.0-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Marcel Hellwig 2013-09-04 15:43:43 UTC
I found a problem in the acutal FindSFML.cmake, if you have both installed.
When you do this:
    find_package(SFML 2 COMPONENTS system REQUIRED)
it will throw out this:
    SFML found but version too low (requested: 2, found: 1.x)

You will have a 50% chance of finding your correct version, otherwise it will break with an error.
The cmake file tries to find the SFML/Config.hpp, which does exist twice, one for the old 1.6 and a new one for 2.0. Depending on which file will be found first, you will have the correct version or not.
You could provide a switch for the version, but that will lead to a nasty workaround, but I don't see any other solution now.
Maybe you can make up your mind.

Comment 8 Hans de Goede 2013-09-04 17:46:18 UTC
(In reply to Marcel Hellwig from comment #7)
> I found a problem in the acutal FindSFML.cmake, if you have both installed.
> When you do this:
>     find_package(SFML 2 COMPONENTS system REQUIRED)
> it will throw out this:
>     SFML found but version too low (requested: 2, found: 1.x)

Well then don't do that. SFML-2.0 comes with pc files as shipped upstream, and cmake is perfectly capable of using pkg-config, and when available that is preferred over find_package, exactly because find_package does this blind groping around until it found something which may or may not work.

I've no intention of supporting building against SFML for projects which don't use pkf-config, so please fix the buildfiles for whatever you're trying to build to use pkg-config.

> You will have a 50% chance of finding your correct version, otherwise it
> will break with an error.
> The cmake file tries to find the SFML/Config.hpp,

Yes, which is the wrong thing todo find_package is broken by design, so better not use it, esp. not when there is a sane alternative in the form of  using pkg-config through pkg_search_module / pkg_search_modules, see /usr/share/cmake/Modules/FindPkgConfig.cmake .

> but I don't see any other solution now.

Use pkg-config is the solution.