Bug 989035
Summary: | Add a missing requirement on crontabs for the cron job to the spec file | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jóhann B. Guðmundsson <johannbg> | ||||
Component: | hplip | Assignee: | Tim Waugh <twaugh> | ||||
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | rawhide | CC: | jpopelka, twaugh | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2013-07-27 06:47:59 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 947037 | ||||||
Attachments: |
|
Description
Jóhann B. Guðmundsson
2013-07-27 01:15:49 UTC
Created attachment 778950 [details]
Spec file fixes patch
I removed [1] it in 3.13.6 because we haven't shipped /etc/cron.daily/hplip_cron since then. Why do you think it's still needed ? [1] http://pkgs.fedoraproject.org/cgit/hplip.git/commit/?id=098fac3992b7e722c6ab2e4c221aedd17f67b4ca (In reply to Jiri Popelka from comment #2) > I removed [1] it in 3.13.6 because we haven't shipped > /etc/cron.daily/hplip_cron since then. Why do you think it's still needed ? Basically because I generated the list of affected components ( around 100 in total 30 of which will potentially be migrated to timer units ) in February after devconf and I'm only really look at the header ( change version number and add the requirement ) and the footer ( add the changelog entry ). Deep spec file inspection takes longer time than to simply generate the patch and later have it closed like you did here. So it's more efficient doing it this way. |