Bug 989035 - Add a missing requirement on crontabs for the cron job to the spec file
Summary: Add a missing requirement on crontabs for the cron job to the spec file
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: hplip
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tim Waugh
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: requires-crontabs
TreeView+ depends on / blocked
 
Reported: 2013-07-27 01:15 UTC by Jóhann B. Guðmundsson
Modified: 2013-07-27 09:49 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-07-27 06:47:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Spec file fixes patch (1.34 KB, patch)
2013-07-27 01:16 UTC, Jóhann B. Guðmundsson
no flags Details | Diff

Description Jóhann B. Guðmundsson 2013-07-27 01:15:49 UTC
Description of problem:

Please update your package according to the packing guidelines
http://fedoraproject.org/wiki/Packaging:CronFiles
Thanks


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Jóhann B. Guðmundsson 2013-07-27 01:16:18 UTC
Created attachment 778950 [details]
Spec file fixes patch

Comment 2 Jiri Popelka 2013-07-27 06:47:59 UTC
I removed [1] it in 3.13.6 because we haven't shipped /etc/cron.daily/hplip_cron since then. Why do you think it's still needed ?

[1] http://pkgs.fedoraproject.org/cgit/hplip.git/commit/?id=098fac3992b7e722c6ab2e4c221aedd17f67b4ca

Comment 3 Jóhann B. Guðmundsson 2013-07-27 09:49:43 UTC
(In reply to Jiri Popelka from comment #2)
> I removed [1] it in 3.13.6 because we haven't shipped
> /etc/cron.daily/hplip_cron since then. Why do you think it's still needed ?

Basically because I generated the list of affected components ( around 100 in total 30 of which will potentially be migrated to timer units )  in February after devconf and I'm only really look at the header ( change version number and add the requirement ) and the footer ( add the changelog entry ).

Deep spec file inspection takes longer time than to simply generate the patch and later have it closed like you did here. So it's more efficient doing it this way.


Note You need to log in before you can comment on or make changes to this bug.