Bug 995522

Summary: dashboard builder should inherit all it's dependency versions from kie-parent-with-dependencies
Product: [Retired] JBoss BPMS Platform 6 Reporter: Geoffrey De Smet <gdesmet>
Component: Build and AssemblyAssignee: Roger Martínez <romartin>
Status: CLOSED CURRENTRELEASE QA Contact: Ivo Bek <ibek>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.0.0CC: pzapataf
Target Milestone: ER4   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Hardcoded dependency versions in dashbuilder artifacts. Consequence: Fix: Add dashboard-builder-bom parent artifact into kie-parent project and remove all versions from dashbuilder artifacts in the whole dashboard-builder project. Result:
 Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:08:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 989519    

Description Geoffrey De Smet 2013-08-09 15:28:48 UTC 
Requirements:
A) Any pom.xml file in droolsjbpm should not declare <version>, except for kie-dependency-with-dependencies. This way, all droolsjbpm modules work with the same version of a dependency and are certain to be compatible.
B) All dependencies that are also a dependency of EAP must use the same version EAP.

dashboard-builder still has about 80 <version> elements specified in it's pom.xml files. This has 3 disadvantages:
- It might use a different version of that dependency then the rest of droolsjbpm
- It won't be extracted to the jboss-integration-platform-bom
- Productization can't easily verify if it's aligned with the rest which they are building.

Recommended steps for jbpm-designer-backend:
1) Remove all dead dependencies first (probably none)
2) Make a list of all dependencies that are not yet specified in kie-dependency-with-dependencies. Add them to kie-dependency-with-dependencies.
3) Compare that list with EAP's dependencies. If EAP uses a different version, specify the EAP version in kie-dependency-with-dependencies.
4) Remove all <version> elements (except to identify the <parent> pom) in the pom.xml files


Skype ge0ffrey for additional info and to discuss.
Comment 2 Roger Martínez 2013-09-30 14:47:36 UTC 
- Added dashboard-builder BOM into droolsjbpm-build-bootstrap project and removed all dependency version from all dashbuilder artifacts.

- Downgraded maven-license-plugin from 1.9.0 to version 1.8.0, as kie-parent uses. No impact detected.

- Added version management into kie-parent-with-dependencies for:
  - org.eclipse.jetty:jetty-server
  - org.eclipse.jetty:jetty-util
Comment 3 Roger Martínez 2013-09-30 14:49:52 UTC 
Commits on master:

- https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/commit/0cdc5381208b8c4af8a92ad58b379a284639662b

- https://github.com/droolsjbpm/dashboard-builder/commit/c6ec72e8162d10d584ec9b054545fff5beebbde3
Comment 4 Roger Martínez 2013-09-30 15:07:06 UTC 
Commits on 6.0.x:

- https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/commit/3031de41c7658f0afda0bb65ef58b2fa91e915c8
- https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/commit/e1da1d6e3e4728b353d0649d43e6bf8c6133f256
- https://github.com/droolsjbpm/dashboard-builder/commit/a68f958a0701a2e0bc9375c822a14bf313bfa369