Bug 998426
| Summary: | there are four "gluster" in qemu-img supported format list | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | mazhang <mazhang> | |
| Component: | qemu-kvm | Assignee: | Jeff Cody <jcody> | |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | |
| Severity: | low | Docs Contact: | ||
| Priority: | low | |||
| Version: | 6.5 | CC: | areis, bsarathy, chayang, juzhang, mazhang, michen, mkenneth, qzhang, rbalakri, virt-maint | |
| Target Milestone: | rc | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | qemu-kvm-0.12.1.2-2.429.el6 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1088695 (view as bug list) | Environment: | ||
| Last Closed: | 2014-10-14 06:50:19 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1088695 | |||
|
Description
mazhang
2013-08-19 09:50:01 UTC
Please check the latest build. qemu-img-0.12.1.2-2.397.el6.x86_64 also hit this issue. We have the same issue with upstream qemu:
qemu-img version 1.5.91, Copyright (c) 2004-2008 Fabrice Bellard
Supported formats: blkdebug blkverify bochs cloop cow dmg gluster gluster gluster gluster iscsi nbd nbd nbd parallels qcow qcow2 qed host_cdrom host_floppy host_device file raw rbd sheepdog sheepdog sheepdog vdi vhdx vmdk vpc vvfat
The issue is we have:
static void bdrv_gluster_init(void)
{
bdrv_register(&bdrv_gluster_rdma);
bdrv_register(&bdrv_gluster_unix);
bdrv_register(&bdrv_gluster_tcp);
bdrv_register(&bdrv_gluster);
}
to register different gluster transport.
Each bdrv is printed in:
bdrv_iterate_format()
Also, please note, sheepdog block driver in upstream also has this problem.
Some block drivers have multiple BlockDriver instances with identical format_name fields (e.g. gluster, nbd). In those cases, the protocol_name is usually the more unique identifier (e.g. gluster+tcp).
Both qemu-img and qemu will use bdrv_iterate_format() to list the supported formats when a help option is invoked. When just the format_name is used, redundant listings of formats occur (e.g., "Supported formats: ... gluster gluster gluster gluster ... ").
If we prefer the protocol_name over the format_name (when the protocol name exists), then that provides a more informative help message:
"Supported formats: ... gluster gluster+tcp gluster+unix gluster+rdma ... "
Patch submitted upstream.
Fix included in qemu-kvm-0.12.1.2-2.429.el6 This bug could be reproduced on qemu-kvm-0.12.1.2-2.428.el6 and verified pass on qemu-kvm-0.12.1.2-2.430.el6. Compared the "#qemu-img" output between the old and new version. [root@localhost ~]# diff old.txt new.txt 1c1 < [root@localhost ~]# qemu-img --- > [root@localhost ~]# qemu-img 53,54c53 < Supported formats: raw cow qcow vdi vmdk cloop dmg bochs vpc vvfat qcow2 qed vhdx parallels nbd blkdebug host_cdrom host_floppy host_device file gluster gluster gluster gluster < --- > Supported formats: raw cow qcow vdi vmdk cloop dmg bochs vpc vvfat qcow2 qed vhdx parallels nbd blkdebug host_cdrom host_floppy host_device file gluster There's only 1 "gluster" in the qemu-img supported format list now. So the bug is fixed. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-1490.html |