Bug 998928

Targeting for 2.1.z U2 (Corbett) release.

This bug has been identified as known issue, hence, please add the DocText.

*** Bug 1058635 has been marked as a duplicate of this bug. ***

Please review the edited Doc Text ans sign off.

why can't we have similar doc text as this bz#989382?

Moving this to ON_QA as the issue was fixed upstream and is now available in RHSC 3.0

(In reply to Sahina Bose from comment #7)
> Moving this to ON_QA as the issue was fixed upstream and is now available in
> RHSC 3.0

I don't see that it's fixed in RHSC 3.0 during my testing. See below:

#################################
[root@dhcp42-228 ]# /etc/init.d/ovirt-engine-notifier start
Starting oVirt Engine Notifier: 
Validation result:
stderr: No transport is enabled, nothing to do
Validation failed returncode is 1:
                                                           [FAILED]
 
[root@dhcp42-228 ]# /etc/init.d/ovirt-engine-notifier status
ovirt-engine-notifier is stopped
#################################


From notifier.log:
#################################
2014-07-09 17:00:03,624 ERROR [org.ovirt.engine.core.notifier.Notifier] Failed to initialize
java.lang.RuntimeException: No transport is enabled, nothing to do
        at org.ovirt.engine.core.notifier.Notifier.main(Notifier.java:63)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.jboss.modules.Module.run(Module.java:312)
        at org.jboss.modules.Main.main(Main.java:460)
#################################


However, looking at https://bugzilla.redhat.com/show_bug.cgi?id=989382#c16 from the cloned RHEVM bug, I could see the following as the fix:

*****************
Verified in  3.4.0-0.7.beta2.el6.

[root@pb-rh34 ~]# /etc/init.d/ovirt-engine-notifier start
Starting oVirt Engine Notifier: 
Validation result:
stderr: Check configuration file, 'MAIL_SERVER' is missing
Validation failed returncode is 1:
                                                           [FAILED]
[root@pb-rh34 ~]# /etc/init.d/ovirt-engine-notifier status
ovirt-engine-notifier is stopped
*****************

Can you check and confirm if the corresponding patch in upstream for this bug is actually availalbe in RHSC 3.0 or if I'm missing something here?

Yes, it is available..
From your test results, the error in the notifier.log is the same as the one that is displayed in the Validation result 
"No transport is enabled, nothing to do"

The reason you see different messages from that mentioned in bug 989382, is because of refactoring done to support SNMP trap as a notification method and hence the generic error message. 
If neither SNMP_MANAGERS nor MAIL_SERVER is configured, this is the message returned.

(In reply to Sahina Bose from comment #9)
> Yes, it is available..
> From your test results, the error in the notifier.log is the same as the one
> that is displayed in the Validation result 
> "No transport is enabled, nothing to do"
> 
> The reason you see different messages from that mentioned in bug 989382, is
> because of refactoring done to support SNMP trap as a notification method
> and hence the generic error message. 
> If neither SNMP_MANAGERS nor MAIL_SERVER is configured, this is the message
> returned.

If the above mentioned error message is the expected result for both rhsc and rhevm, you may move this bug back to ON_QA for further verification. 

But I feel that the following error message gives more meaningful message to the customers:

-----
stderr: Check configuration file, 'MAIL_SERVER'or SNMP_MANAGERS is missing
Validation failed returncode is 1:
-----

What is your thought on that?

Moving bug back as this is the expected error in both RHSC and RHEVM currently.

Regarding the suggested error message, yes - this is more informative. This could be incorporated in a later release if feasible. Adding mperina for info

(In reply to Sahina Bose from comment #11)
> Moving bug back as this is the expected error in both RHSC and RHEVM
> currently.
> 
> Regarding the suggested error message, yes - this is more informative. This
> could be incorporated in a later release if feasible. Adding mperina for info

Based on the above comment, marking this bug as Verified.

#########
[root@dhcp42-228 ~]# /etc/init.d/ovirt-engine-notifier start
Starting oVirt Engine Notifier: 
Validation result:
stderr: No transport is enabled, nothing to do
Validation failed returncode is 1:
                                                           [FAILED]
[root@dhcp42-228 ~]# 
[root@dhcp42-228 ~]# 
[root@dhcp42-228 ~]# /etc/init.d/ovirt-engine-notifier status
ovirt-engine-notifier is stopped
#########

Once I hear from mperina, I'll go ahead and open a BZ for improving this error message.

It's not a problem to change error message, I created following bug BZ1136026 for this with suggested error message:

  "No transport is enabled, please enable at least one of SMTP (using MAIL_SERVER option) or SNMP (using SNMP_MANAGERS option) transports"

If you would like to change it, please suggest different content in BZ1136026

Hi Bala, 

I have edited the doc text. Kindly verify it for technical accuracy and sign-off.

Looks good to me.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2014-1277.html