Cloning this bug for RHSC for tracking as the Product of the original bug had been changed to RHEVM.

+++ This bug was initially created as a clone of Bug #989382 +++

Description of problem:

No error message seen while starting "ovirt-engine-notifier" when "MAIL_SERVER" is NOT defined

Version-Release number of selected component (if applicable):  Red Hat Storage Console Version: 2.1.0-0.bb6.el6rhs 


How reproducible: Always


Steps to Reproduce:
1. # /etc/init.d/ovirt-engine-notifier start
2 .# /etc/init.d/ovirt-engine-notifier status


Actual results:

[root@rhs-client3 conf]# /etc/init.d/ovirt-engine-notifier start
Starting oVirt Engine Notifier:                            [  OK  ]                                                                                                                           
[root@rhs-client3 conf]# /etc/init.d/ovirt-engine-notifier status
 dead but pid file exists


Expected results:

If the MAIL_SERVER is not defined, we should be getting a meaningful error message something like: "Error: $MAIL_SERVER is not defined, please check for this in configuration file" instead of simply starting the service and showing the status as "dead but pid file exists". In short, the error message should be proper and provide a useful message to the user.

--- Additional comment from RHEL Product and Program Management on 2013-07-29 04:16:45 EDT ---

Since this issue was entered in bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

--- Additional comment from Sahina Bose on 2013-07-31 10:12:58 EDT ---

The issue still exists so moving back to Assigned

--- Additional comment from Alon Bar-Lev on 2013-08-07 02:28:01 EDT ---

Yair,
What about this one?
Alon

--- Additional comment from Yair Zaslavsky on 2013-08-12 08:45:12 EDT ---

infra will take ownership of tihs one.

--- Additional comment from Alon Bar-Lev on 2013-08-13 06:12:18 EDT ---

To summarize:

Any error of service startup should be written to the service log file:

/var/log/ovirt-engine/notifier/notifier.log

The problem in rhel is that for some reason the log file is created but no messages are written into. This works OK on fedora with the same configuration.

--- Additional comment from Martin Perina on 2013-08-13 06:43:41 EDT ---

Can you see an error in /var/log/ovirt-engine/notifier/notifier.log? In particular there should be something like:

Check configuration file, 'MAIL_SERVER' is missing

If your notifier.log is empty, then it's a problem described in http://bugzilla.redhat.com/989422

--- Additional comment from Prasanth on 2013-08-19 06:29:14 EDT ---

(In reply to Martin Perina from comment #6)
> Can you see an error in /var/log/ovirt-engine/notifier/notifier.log? In
> particular there should be something like:
> 
> Check configuration file, 'MAIL_SERVER' is missing
> 
> If your notifier.log is empty, then it's a problem described in
> http://bugzilla.redhat.com/989422

Yes, I can see the following in the logs:

-------------
2013-08-19 15:57:19,584 ERROR [org.ovirt.engine.core.notifier.Notifier] Failed to run the event notification service. 
java.lang.IllegalArgumentException: Check configuration file, 'MAIL_SERVER' is missing
        at org.ovirt.engine.core.notifier.Notifier.main(Notifier.java:82)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.jboss.modules.Module.run(Module.java:270)
        at org.jboss.modules.Main.main(Main.java:411)
-------------

--- Additional comment from Alon Bar-Lev on 2013-08-19 06:53:56 EDT ---

(In reply to Prasanth from comment #7)
> (In reply to Martin Perina from comment #6)
> > Can you see an error in /var/log/ovirt-engine/notifier/notifier.log? In
> > particular there should be something like:
> > 
> > Check configuration file, 'MAIL_SERVER' is missing
> > 
> > If your notifier.log is empty, then it's a problem described in
> > http://bugzilla.redhat.com/989422
> 
> Yes, I can see the following in the logs:
> 
> -------------
> 2013-08-19 15:57:19,584 ERROR [org.ovirt.engine.core.notifier.Notifier]
> Failed to run the event notification service. 
> java.lang.IllegalArgumentException: Check configuration file, 'MAIL_SERVER'
> is missing

So we are ok. Strange how the jboss change does not effect your environment.

--- Additional comment from Martin Perina on 2013-08-27 08:07:56 EDT ---

So, your complain is that this error message is not displayed during execution of
"/etc/init.d/ovirt-engine-notifier start"?

--- Additional comment from Sahina Bose on 2013-09-06 06:23:41 EDT ---

Yes, the complaint is that, if MAIL_SERVER is not configured,
service ovirt-engine-notifier start -> reports ok
service ovirt-engine-notifier status -> says "dead but pif file exists"

--- Additional comment from Pavithra on 2013-09-06 06:35:35 EDT ---

I have updated the doc text and attached the 2.1 RN as well. Please review the text and sign off.

--- Additional comment from Pavithra on 2013-09-06 07:10:01 EDT ---



--- Additional comment from Andrew Cathrow on 2013-09-16 09:30:13 EDT ---

Not exception material.
Let's see if we can improve the text to tell a user that the service is starting rather than giving a successful return code.

Moving to 3.4
Let's see if we get cycles to improve this in 3.3.z

--- Additional comment from Martin Perina on 2014-01-09 08:35:02 EST ---

For systemd error is returned during start command, status command shows details.
For initscripts error message is displayed during start command.

--- Additional comment from Sandro Bonazzola on 2014-01-14 03:43:33 EST ---

ovirt 3.4.0 alpha has been released