Spec URL: http://cheeselee.fedorapeople.org/fcitx-anthy.spec SRPM URL: http://cheeselee.fedorapeople.org/fcitx-anthy-0.2.0-1.fc19.src.rpm Description: Fcitx-anthy is an Anthy engine wrapper for Fcitx. It provides a Japanese input method. Fedora Account System Username: cheeselee
*** Bug 887907 has been marked as a duplicate of this bug. ***
Directories without known owners: %{_datadir}/fcitx/anthy/*.sty ---> %{_datadir}/fcitx/anthy =========== Suggestion: Name: fcitx-anthy Version: 0.2.0 Release: 1%{?dist} Summary: Anthy Engine for Fcitx Group: System Environment/Libraries License: GPLv2+ URL: https://fcitx-im.org/wiki/Anthy Source0: http://download.fcitx-im.org/fcitx-anthy/%{name}-%{version}.tar.xz BuildRequires: cmake BuildRequires: fcitx-devel BuildRequires: gettext BuildRequires: intltool BuildRequires: anthy-devel Requires: fcitx Auh, a bit ugly... Name: fcitx-anthy Version: 0.2.0 Release: 1%{?dist} Summary: Anthy Engine for Fcitx Group: System Environment/Libraries License: GPLv2+ URL: https://fcitx-im.org/wiki/Anthy Source0: http://download.fcitx-im.org/fcitx-anthy/%{name}-%{version}.tar.xz BuildRequires: anthy-devel BuildRequires: cmake BuildRequires: fcitx-devel BuildRequires: gettext BuildRequires: intltool Requires: fcitx Also, %description is too short. Orig: Fcitx-anthy is an Anthy engine wrapper for Fcitx. It provides a Japanese input method. Mine: Fcitx-anthy is an Anthy engine wrapper for Fcitx based on scim-anthy. It provides a Japanese input method. Users can input Japanese hiragana and katakana by inputting romaji via fcitx-anthy. Fcitx-anthy can also convert hiragana or katakana to Japanese kanji after inputting hiragana or katakana. ************************************* Please FIX the issue before SCM. APPROVED.
Spec URL: http://cheeselee.fedorapeople.org/fcitx-anthy.spec SRPM URL: http://cheeselee.fedorapeople.org/fcitx-anthy-0.2.0-2.fc19.src.rpm Changes: - Own the diretory %%{_datadir}/fcitx/anthy/ - description enlarged (In reply to Christopher Meng from comment #2) > Directories without known owners: > > %{_datadir}/fcitx/anthy/*.sty > > ---> > > %{_datadir}/fcitx/anthy > > > =========== > > Suggestion: > > Name: fcitx-anthy > Version: 0.2.0 > Release: 1%{?dist} > Summary: Anthy Engine for Fcitx > Group: System Environment/Libraries > License: GPLv2+ > URL: https://fcitx-im.org/wiki/Anthy > Source0: http://download.fcitx-im.org/fcitx-anthy/%{name}-%{version}.tar.xz > BuildRequires: cmake > BuildRequires: fcitx-devel > BuildRequires: gettext > BuildRequires: intltool > BuildRequires: anthy-devel > Requires: fcitx > > Auh, a bit ugly... > > Name: fcitx-anthy > Version: 0.2.0 > Release: 1%{?dist} > Summary: Anthy Engine for Fcitx > Group: System Environment/Libraries > License: GPLv2+ > URL: https://fcitx-im.org/wiki/Anthy > Source0: http://download.fcitx-im.org/fcitx-anthy/%{name}-%{version}.tar.xz > BuildRequires: anthy-devel > BuildRequires: cmake > BuildRequires: fcitx-devel > BuildRequires: gettext > BuildRequires: intltool > Requires: fcitx The specfile is aligned with tabs. If you set tab as 4 spaces in you editor, you will get a cleanly aligned view. > > Also, %description is too short. > > Orig: > > Fcitx-anthy is an Anthy engine wrapper for Fcitx. It > provides a Japanese input method. > > > Mine: > > Fcitx-anthy is an Anthy engine wrapper for Fcitx based on scim-anthy. It > provides a Japanese input method. Users can input Japanese hiragana and > katakana by inputting romaji via fcitx-anthy. Fcitx-anthy can also convert > hiragana or katakana to Japanese kanji after inputting hiragana or katakana. OK. I have revised it with respect to your suggestion. > > ************************************* > > Please FIX the issue before SCM. > > APPROVED.
Thanks for your review! New Package SCM Request ======================= Package Name: fcitx-anthy Short Description: Anthy Engine for Fcitx Owners: cheeselee Branches: f18 f19 f20 InitialCC: i18n-team
Git done (by process-git-requests).
fcitx-anthy-0.2.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fcitx-anthy-0.2.0-2.fc18
fcitx-anthy-0.2.0-2.fc18 has been pushed to the Fedora 18 testing repository.
fcitx-anthy-0.2.0-2.fc18 has been pushed to the Fedora 18 stable repository.