Fedora Account System
Red Hat Associate
Red Hat Customer
SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-anthy-0.1.1-1.fc17.src.rpm SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-anthy.spec Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4796846 Description: Fcitx-anthy is a Anthy engine wrapper for Fcitx. It Provides Japanese input method from anthy.
Hi Liang: - Don't need (-n %{name}-%{version}) in the %setup, - Please write a detailed list (one per line) of the BuildRequires - Remove rm -rf $RPM_BUILD_ROOT of the %install (This only applies to packages epel5) - Remove section %clean (The %clean section is not required for F-13 and above.) - Remove %defattr(-,root,root,-) (This only applies to packages epel5) Now let's review the output rpmlint fcitx-anthy-0.1.1-1.fc17.src.rpm fcitx-anthy-0.1.1-1.fc17.x86_64.rpm fcitx-anthy-debuginfo-0.1.1-1.fc17.x86_64.rpm - Please, be consistent between the tag release and the changelog fcitx-anthy.x86_64: W: incoherent-version-in-changelog 0.1.2-1 ['0.1.1-1.fc17', '0.1.1-1'] - FSF postal address is wrong: Please contact the upstream , to correct it. https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/nicola-f.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/doc/fcitx-anthy-0.1.1/COPYING fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/msime.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/tron-dvorak.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/vje-delta.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/canna.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/nicola-j.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/oasys100j.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/tsuki-2-203-106.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/tsuki-2-203-101.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/azik.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/101kana.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/tron-qwerty-jp.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/atok.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/wnn.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/nicola-a.sty
I upload a new spec and a new srpm. SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-anthy-0.1.1-1.fc17.src.rpm SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-anthy.spec Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4799953 I have contacted with upstream and told him about FSF address issue. He will fix it soon.
Update: FSF address issue has been fixed. SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-anthy-0.1.1-1.fc17.src.rpm SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-anthy.spec Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4800140
Hi Liang I'll take the review But first some comments: - Please bump the release number of the spec file on changes and try to write a meaningful changelog entry (So far you have made three changes and these should be reflected in the changelog) https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs - I've seen the patch, and I find that has patched the COPYING file (license) --- a/COPYING +++ b/COPYING @@ -2,7 +2,7 @@ Version 2, June 1991 Copyright (C) 1989, 1991 Free Software Foundation, Inc. - 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. @@ -305,7 +305,7 @@ the "copyright" line and a pointer to where the full notice is found. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. In the explanation of the common rpmlint issues, can be read in https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address The license file, usually COPYING, must not be patched for legal reasons. Other files can be patched if deemed suitable
ping Liang Also, have you heard anything from upstream on the licenses?
Ping again Liang, Could you please give me an answer on this package? Regards
Any news here?
any update here?
I take over this package and filed a new review request. *** This bug has been marked as a duplicate of bug 1000583 ***