Bug 1003961 - installer (katello-configure) fails to report some errors
Summary: installer (katello-configure) fails to report some errors
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Installation
Version: 6.0.2
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: Unspecified
Assignee: Ivan Necas
QA Contact: Og Maciel
URL: https://github.com/Katello/katello-in...
Whiteboard:
: 1012068 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-03 14:59 UTC by Mike McCune
Modified: 2014-04-11 16:51 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-11 16:51:46 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Mike McCune 2013-09-03 14:59:04 UTC
Certain error conditions which result in Satellite 6 not being correctly configured do not show any errors in the output of katello-configure.  

It is possible that errors are logged in the puppet output but the run of katello-configure just looks like:

# katello-configure
Starting Katello configuration
The top-level log file is [/var/log/katello/katello-configure-20130903-075425/main.log]
Katello configuration: |==================|
#


As the user this looks like the command succeeded but if you search through /var/log/katello/katello-configure/* there still may be ERROR lines indicating issues during the puppet run.

We need to have our installer check the log files at the end and better report if errors occurred so the user does not think that the setup is complete.

Comment 1 Mike McCune 2013-09-03 15:00:54 UTC
An example would be this bug:

https://bugzilla.redhat.com/show_bug.cgi?id=995986

if you search through the katello-debug you will note that in db_migrate.log file there is:

rake aborted!
cannot load such file -- ./engines/bastion/lib/bastion
/opt/rh/ruby193/root/usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
/opt/rh/ruby193/root/usr/share/rubygems/rubygems/custom_require.rb:36:in `require'


yet katello-configure failed without any error indication.

Comment 3 Mike McCune 2013-10-15 14:20:50 UTC
some options we talked about on the phone:

* Check the service status at the end of the run

* Check the puppet exit code

* Possibly grep the log file for errors but this may show things that are non-fatal

Comment 4 Ivan Necas 2013-10-17 13:20:04 UTC
*** Bug 1012068 has been marked as a duplicate of this bug. ***

Comment 5 Ivan Necas 2013-10-17 13:45:28 UTC
Proposed fix in https://github.com/Katello/katello-installer/pull/60. There was change in log output format for newer puppet, that we needed to accomodate.

Also there is a check at the end to make sure all the required services are running.

The exit code from puppet was not usable because it was 0 even when something failed. We could go for puppet --detailedexitcode, but since the katello-configure is going to get replaced with node-installer, it doesn't make much sense to do so, as the current checks should be sufficient for the time being.

Comment 6 Ivan Necas 2013-10-21 15:06:53 UTC
Merged

Comment 9 Og Maciel 2013-10-25 16:38:43 UTC
Could not reproduce it anymore. Please re-open it if needed.

Comment 12 sthirugn@redhat.com 2014-04-11 16:32:26 UTC
I was testing SAM 1.4 compose.  I tried katello-configure in free_ipa mode.  the katello-configure exited with no errors. But: 

# katello-service status
tomcat6 (pid 142911) is running...[  OK  ]
httpd (pid  143373) is running...
thumbslug (pid  143164) is running...
elasticsearch (pid  142723) is running...
katello is not running.
delayed_job is not running.
delayed_job_monitor is not running.

katello-configure should report failure if it failed to start any of the required katello-services isnt it?

Comment 13 sthirugn@redhat.com 2014-04-11 16:33:19 UTC
Reopening the bug based on my comment above

Comment 14 Mike McCune 2014-04-11 16:49:57 UTC
For SAM 2.0 and Sat6 GA we have an entirely re-written installer that does a better job of notification upon installation failure.  I'd be hesitant to go back and enhance any of the error reporting on the old katello-configure routines.

Should consider CLOSED:WONTFIX

Comment 15 sthirugn@redhat.com 2014-04-11 16:51:46 UTC
Agreed to Mike McCune's comment above.


Note You need to log in before you can comment on or make changes to this bug.