Spec URL: http://cicku.me/perl-Date-HolidayParser.spec SRPM URL: http://cicku.me/perl-Date-HolidayParser-0.41-1.fc21.src.rpm Description: This is a module that parses .holiday-style files. These are files that define holidays in various parts of the world. The files are easy to write and easy for humans to read, but can be hard to parse because the format allows many different ways to write it. Fedora Account System Username: cicku
This bug needs be solved quickly as it's a missing dependency of dayplanner package.
dayplanner has been in Fedora for 5+ years, so a missing dependency is doubtful. It may be necessary for an upgrade, but the same situation is very common for other packages as well. Please don't usurp the severity, otherwise the whole review queue will quickly turn red.
(In reply to Susi Lehtola from comment #2) > dayplanner has been in Fedora for 5+ years, so a missing dependency is > doubtful. It may be necessary for an upgrade, but the same situation is very > common for other packages as well. Please don't usurp the severity, > otherwise the whole review queue will quickly turn red. Thanks. But I think we need it urgently as dayplanner from 0.11 really requires that.
I will review this tomorrow.
+ Package builds fine in mock + rpmlint on rpms gave perl-Date-HolidayParser.noarch: I: checking perl-Date-HolidayParser.noarch: I: checking-url http://search.cpan.org/dist/Date-HolidayParser/ (timeout 10 seconds) perl-Date-HolidayParser.src: I: checking perl-Date-HolidayParser.src: I: checking-url http://search.cpan.org/dist/Date-HolidayParser/ (timeout 10 seconds) perl-Date-HolidayParser.src: I: checking-url http://www.cpan.org/authors/id/Z/ZE/ZERODOGG/Date-HolidayParser-0.41.tar.gz (timeout 10 seconds) 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) srpm : ec38a54a4029ca3796d3e9a46a231603911f51133e3a8203c6b71588c527d17c upstream : ec38a54a4029ca3796d3e9a46a231603911f51133e3a8203c6b71588c527d17c + License tag is valid + make test gave All tests successful. Files=3, Tests=374, 0 wallclock secs ( 0.06 usr 0.01 sys + 0.19 cusr 0.02 csys = 0.28 CPU) + Package perl-Date-HolidayParser-0.41-1.fc21.noarch Provides: perl(Date::HolidayParser) = 0.4 perl(Date::HolidayParser::iCalendar) = 0.41 perl-Date-HolidayParser = 0.41-1.fc21 Requires: perl(Any::Moose) perl(Carp) perl(Date::HolidayParser) perl(Exporter) perl(POSIX) perl(constant) Suggestions: 1) Remove following as it will be installed by yum automatically Requires: perl(Any::Moose) Requires: perl(Test::More) 2) Though license tag is valid based on license terms written in .pl files, COPYING* files have different license text. Good to get this clarified with upstream.
Spec URL: http://cicku.me/perl-Date-HolidayParser.spec SRPM URL: http://cicku.me/perl-Date-HolidayParser-0.41-2.fc21.src.rpm Clarification from upstream: The correct license is the one listed in the COPYING file, that is to say «GNU GPLv3 or later» as well as the artistic license. I see that the perl files themselves list only a short GPL blurb, that's because this library used to be bundled with Day Planner but was split into its own project and relicensed from «GPLv3 and later» only, to the standard Perl dual-license as part of that split.
Good to add this information in spec about upstream clarification. APPROVED.
Thanks! New Package SCM Request ======================= Package Name: perl-Date-HolidayParser Short Description: Parser for .holiday-files Owners: cicku Branches: f20 f19
Git done (by process-git-requests).
perl-Date-HolidayParser-0.41-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Date-HolidayParser-0.41-2.fc20
perl-Date-HolidayParser-0.41-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Date-HolidayParser-0.41-2.fc19
perl-Date-HolidayParser-0.41-2.fc20 has been pushed to the Fedora 20 testing repository.
perl-Date-HolidayParser-0.41-2.fc19 has been pushed to the Fedora 19 stable repository.
perl-Date-HolidayParser-0.41-2.fc20 has been pushed to the Fedora 20 stable repository.