+++ This bug was initially created as a clone of Bug #1010239 +++ Description of problem: executed the tool nfstest_posix tool Version-Release number of selected component (if applicable): glusterfs-3.4.0.33rhs-1.el6rhs How reproducible: always Steps to Reproduce: 1. execute nfstest-posix testsuite. 2. 3. Actual results: patchset: git://git.gluster.com/glusterfs.git signal received: 11 time of crash: 2013-09-20 10:13:38configuration details: argp 1 backtrace 1 dlfcn 1 fdatasync 1 libpthread 1 llistxattr 1 setfsid 1 spinlock 1 epoll.h 1 xattr.h 1 st_atim.tv_nsec 1 package-string: glusterfs 3.4.0.33rhs /lib64/libc.so.6[0x3cdd832960] /usr/lib64/glusterfs/3.4.0.33rhs/xlator/nfs/server.so(nfs3_stat_to_fattr3+0x28)[0x7f56114568f8] /usr/lib64/glusterfs/3.4.0.33rhs/xlator/nfs/server.so(nfs3_fill_getattr3res+0x35)[0x7f5611456b25] /usr/lib64/glusterfs/3.4.0.33rhs/xlator/nfs/server.so(nfs3_getattr_reply+0x3a)[0x7f561144494a] /usr/lib64/glusterfs/3.4.0.33rhs/xlator/nfs/server.so(nfs3svc_getattr_stat_cbk+0x4d)[0x7f561144776d] /usr/lib64/glusterfs/3.4.0.33rhs/xlator/nfs/server.so(nfs_fop_stat_cbk+0x41)[0x7f561143bc91] /usr/lib64/glusterfs/3.4.0.33rhs/xlator/debug/io-stats.so(io_stats_stat_cbk+0xf6)[0x7f56118f7196] /usr/lib64/libglusterfs.so.0(default_stat_cbk+0xc2)[0x3981426742] /usr/lib64/glusterfs/3.4.0.33rhs/xlator/cluster/distribute.so(dht_attr2+0x234)[0x7f5611d438a4] /usr/lib64/glusterfs/3.4.0.33rhs/xlator/cluster/distribute.so(+0xb196)[0x7f5611d1a196] /usr/lib64/libglusterfs.so.0(synctask_wrap+0x2a)[0x398144983a] /lib64/libc.so.6[0x3cdd843bb0] --------- Expected results: crash is not expected Additional info:
NFS must do a NULL check in nfs3_stat_to_fattr3() routine avoid SEGV but the problem seems to be from DHT side. DHT sends down upto NFS with op_errno as 0 and op_ret as -1 which looks confusing. Needs more investigation who is masking the actual errno. The way dht_migration_complete_check() does lookup for the file, is also not clear. Will work with DHT team.
REVIEW: http://review.gluster.org/6026 (gNFS: NFS segfaults with nfstest_posix tool) posted (#1) for review on master by Santosh Pradhan (spradhan)
REVIEW: http://review.gluster.org/6026 (gNFS: NFS segfaults with nfstest_posix tool) posted (#2) for review on master by Santosh Pradhan (spradhan)
I am done with the FIX from NFS side. I am assigning the bug to Raghavendra Gowdappa so that he can put the FIX from DHT side. Idea is to commit the changes from same BZ id.
REVIEW: http://review.gluster.org/6219 (cluster/dht: set op_errno correctly during migration.) posted (#1) for review on master by Raghavendra G (rgowdapp)
COMMIT: http://review.gluster.org/6026 committed in master by Vijay Bellur (vbellur) ------ commit 0b2487d3bc8bc526d9b08698ea1434e94a6420d5 Author: Santosh Kumar Pradhan <spradhan> Date: Fri Sep 20 16:58:47 2013 +0530 gNFS: NFS segfaults with nfstest_posix tool Problem: nfs3_stat_to_fattr3() missed a NULL check. FIX: (1) Added a NULL check. (2) In all fop cbk path, if the op_ret is -1 and op_errno is 0, then handle it as a special case. Set the NFS3 status as NFS3ERR_SERVERFAULT instead of NFS3_OK. (3) The other component of FIX would be in DHT module and is on the way. Change-Id: I6f03c9a02d794f8b807574f2755094dab1b90c92 BUG: 1010241 Signed-off-by: Santosh Kumar Pradhan <spradhan> Reviewed-on: http://review.gluster.org/6026 Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Vijay Bellur <vbellur> Tested-by: Gluster Build System <jenkins.com>
REVIEW: http://review.gluster.org/6219 (cluster/dht: set op_errno correctly during migration.) posted (#2) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/6219 (cluster/dht: set op_errno correctly during migration.) posted (#3) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/6219 (cluster/dht: set op_errno correctly during migration.) posted (#4) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/6219 (cluster/dht: set op_errno correctly during migration.) posted (#5) for review on master by Raghavendra G (rgowdapp)
COMMIT: http://review.gluster.org/6219 committed in master by Anand Avati (avati) ------ commit c0c1210ffd5a45a47a3ad6a61545145f1a8e129c Author: Raghavendra G <rgowdapp> Date: Mon Nov 4 16:21:14 2013 +0530 cluster/dht: set op_errno correctly during migration. Change-Id: I65acedf92c1003975a584a2ac54527e9a2a1e52f BUG: 1010241 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/6219 Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati>
REVIEW: http://review.gluster.org/6817 (cluster/dht: set op_errno correctly during migration.) posted (#1) for review on release-3.5 by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/6817 (cluster/dht: set op_errno correctly during migration.) posted (#2) for review on release-3.5 by Raghavendra G (rgowdapp)
COMMIT: http://review.gluster.org/6817 committed in release-3.5 by Vijay Bellur (vbellur) ------ commit 0483c68e0d05f1285baff22609f2ec6be65a5306 Author: Raghavendra G <rgowdapp> Date: Mon Nov 4 16:21:14 2013 +0530 cluster/dht: set op_errno correctly during migration. Change-Id: I65acedf92c1003975a584a2ac54527e9a2a1e52f BUG: 1010241 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/6219 Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> Reviewed-on: http://review.gluster.org/6817 Reviewed-by: Vijay Bellur <vbellur>
This can possibly get closed when bug 1099270 is fixed.
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED. Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html [2] http://supercolony.gluster.org/pipermail/gluster-users/
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report. glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html [2] http://supercolony.gluster.org/mailman/listinfo/gluster-users