Bug 1010241

NFS must do a NULL check in nfs3_stat_to_fattr3() routine avoid SEGV but the problem seems to be from DHT side. DHT sends down upto NFS with op_errno as 0 and op_ret as -1 which looks confusing. Needs more investigation who is masking the actual errno. The way dht_migration_complete_check() does lookup for the file, is also not clear.  Will work with DHT team.

REVIEW: http://review.gluster.org/6026 (gNFS: NFS segfaults with nfstest_posix tool) posted (#1) for review on master by Santosh Pradhan (spradhan)

REVIEW: http://review.gluster.org/6026 (gNFS: NFS segfaults with nfstest_posix tool) posted (#2) for review on master by Santosh Pradhan (spradhan)

I am done with the FIX from NFS side. I am assigning the bug to Raghavendra Gowdappa so that he can put the FIX from DHT side. Idea is to commit the changes from same BZ id.

REVIEW: http://review.gluster.org/6219 (cluster/dht: set op_errno correctly during migration.) posted (#1) for review on master by Raghavendra G (rgowdapp)

COMMIT: http://review.gluster.org/6026 committed in master by Vijay Bellur (vbellur) 
------
commit 0b2487d3bc8bc526d9b08698ea1434e94a6420d5
Author: Santosh Kumar Pradhan <spradhan>
Date:   Fri Sep 20 16:58:47 2013 +0530

    gNFS: NFS segfaults with nfstest_posix tool
    
    Problem:
    nfs3_stat_to_fattr3() missed a NULL check.
    
    FIX:
    (1) Added a NULL check.
    (2) In all fop cbk path, if the op_ret is -1 and op_errno is 0,
        then handle it as a special case. Set the NFS3 status as
        NFS3ERR_SERVERFAULT instead of NFS3_OK.
    (3) The other component of FIX would be in DHT module and
        is on the way.
    
    Change-Id: I6f03c9a02d794f8b807574f2755094dab1b90c92
    BUG: 1010241
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/6026
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

REVIEW: http://review.gluster.org/6219 (cluster/dht: set op_errno correctly during migration.) posted (#2) for review on master by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/6219 (cluster/dht: set op_errno correctly during migration.) posted (#3) for review on master by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/6219 (cluster/dht: set op_errno correctly during migration.) posted (#4) for review on master by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/6219 (cluster/dht: set op_errno correctly during migration.) posted (#5) for review on master by Raghavendra G (rgowdapp)

COMMIT: http://review.gluster.org/6219 committed in master by Anand Avati (avati) 
------
commit c0c1210ffd5a45a47a3ad6a61545145f1a8e129c
Author: Raghavendra G <rgowdapp>
Date:   Mon Nov 4 16:21:14 2013 +0530

    cluster/dht: set op_errno correctly during migration.
    
    Change-Id: I65acedf92c1003975a584a2ac54527e9a2a1e52f
    BUG: 1010241
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/6219
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

REVIEW: http://review.gluster.org/6817 (cluster/dht: set op_errno correctly during migration.) posted (#1) for review on release-3.5 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/6817 (cluster/dht: set op_errno correctly during migration.) posted (#2) for review on release-3.5 by Raghavendra G (rgowdapp)

COMMIT: http://review.gluster.org/6817 committed in release-3.5 by Vijay Bellur (vbellur) 
------
commit 0483c68e0d05f1285baff22609f2ec6be65a5306
Author: Raghavendra G <rgowdapp>
Date:   Mon Nov 4 16:21:14 2013 +0530

    cluster/dht: set op_errno correctly during migration.
    
    Change-Id: I65acedf92c1003975a584a2ac54527e9a2a1e52f
    BUG: 1010241
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/6219
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/6817
    Reviewed-by: Vijay Bellur <vbellur>

This can possibly get closed when bug 1099270 is fixed.

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users