Bug 1010727 - (qt5-qtdoc) Review Request: qt5-qtdoc - Main Qt5 Reference Documentation
Review Request: qt5-qtdoc - Main Qt5 Reference Documentation
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Lubomir Rintel
Fedora Extras Quality Assurance
: 1009868 (view as bug list)
Depends On:
Blocks: qt-reviews
  Show dependency treegraph
Reported: 2013-09-22 16:41 EDT by Rex Dieter
Modified: 2014-09-23 13:13 EDT (History)
4 users (show)

See Also:
Fixed In Version: qt5-qtdoc-5.1.1-2.fc20
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2013-10-19 05:14:10 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lkundrak: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Rex Dieter 2013-09-22 16:41:12 EDT
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdoc.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdoc-5.1.1-1.fc19.src.rpm
QtDoc contains the main Qt Reference Documentation, which includes
overviews, Qt topics, and examples not specific to any Qt module

Fedora Account System Username: rdieter

Scratch build:
Comment 1 Lubomir Rintel 2013-09-23 03:00:08 EDT
* Package is correctly named
* Correct version packaged
* License correct and packaged
* Source file untouched
* RPM file clean and legible
* Requires sane
* Provides sane
- Filelist mostly fine, see notes below
* Builds fine in mock
* RPMLint happy

0.) The package should not have %doc-only files.

I'm pretty sure there's even a guideline (that applies to -doc subpackages, but the point stays) -- I'll try to look it up in case this does not make sense to you :)

However, the purpose of marking files %doc is nodocs RPM transaction that would allow for very minimal installation that still not affect functionality of the system. In such case a person would not install the -qtdoc package in the first place.

I suggest not marking /usr/share/doc/qt5/qtdoc as %doc, and only leaving /usr/share/doc/qt5-qtdoc-5.1.1 to be marked as such.
Comment 2 Kevin Kofler 2013-09-26 18:49:52 EDT
RPM automatically marks everything under /usr/share/doc as %doc, so just removing the %doc wouldn't help.
Comment 3 Kevin Kofler 2013-09-26 19:08:24 EDT
> License: LGPLv2 with exceptions or GPLv3 with exceptions and GFDL

Shouldn't that actually say:
License: (LGPLv2 with exceptions or GPLv3 with exceptions) and GFDL
instead? At least in C and C++, && has higher priority than ||.

(This also affects at least qt5-qttranslations, probably also other Qt 5 packages.)
Comment 4 Rex Dieter 2013-09-30 11:41:14 EDT
Kevin's right, the %doc marking is automatic, notice there is no '%doc' anywhere in qt5-qtdoc.spec 

As far as licensing goes, since it is doc-only, probably only GFDL applies here.  I'll double-check...
Comment 5 Rex Dieter 2013-09-30 11:45:09 EDT

Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdoc.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdoc-5.1.1-2.fc19.src.rpm

* Mon Sep 30 2013 Rex Dieter <rdieter@fedoraproject.org> 5.1.1-2
- License: GFDL
Comment 6 Lubomir Rintel 2013-10-09 04:57:51 EDT
Thank you.

Comment 7 Rex Dieter 2013-10-09 13:06:28 EDT
New Package SCM Request
Package Name: qt5-qtdoc
Short Description: Main Qt5 Reference Documentation
Owners: than rdieter jreznik kkofler ltinkl rnovacek
Branches: el6 f18 f19 f20
Comment 8 Gwyn Ciesla 2013-10-09 14:33:35 EDT
Git done (by process-git-requests).
Comment 9 Fedora Update System 2013-10-10 09:53:14 EDT
qt5-qtdoc-5.1.1-2.fc20 has been submitted as an update for Fedora 20.
Comment 10 Fedora Update System 2013-10-10 09:53:44 EDT
qt5-qtdoc-5.1.1-2.fc19 has been submitted as an update for Fedora 19.
Comment 11 Fedora Update System 2013-10-10 09:54:43 EDT
qt5-qtdoc-5.1.1-2.fc18 has been submitted as an update for Fedora 18.
Comment 12 Fedora Update System 2013-10-10 09:55:26 EDT
qt5-qtdoc-5.1.1-2.el6 has been submitted as an update for Fedora EPEL 6.
Comment 13 Fedora Update System 2013-10-10 14:32:55 EDT
qt5-qtdoc-5.1.1-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
Comment 14 Fedora Update System 2013-10-19 05:14:10 EDT
qt5-qtdoc-5.1.1-2.fc19 has been pushed to the Fedora 19 stable repository.
Comment 15 Fedora Update System 2013-10-19 05:14:26 EDT
qt5-qtdoc-5.1.1-2.fc18 has been pushed to the Fedora 18 stable repository.
Comment 16 Fedora Update System 2013-10-25 13:36:48 EDT
qt5-qtdoc-5.1.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Comment 17 Fedora Update System 2013-11-10 01:32:34 EST
qt5-qtdoc-5.1.1-2.fc20 has been pushed to the Fedora 20 stable repository.
Comment 18 Rex Dieter 2014-09-23 13:13:33 EDT
*** Bug 1009868 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.