Red Hat Bugzilla – Bug 101304
Panel uses theme icon instead of specified one for launchers
Last modified: 2007-04-18 12:56:24 EDT
Description of problem:
When specifying an icon via a launcher's properties, the panel prefers a
Bluecurve icon with the same name, while the icon shown in the launcher's
properties is the specified one.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Try to set the icon for e.g. Evolution to /usr/share/pixmaps/evolution.png
2. Watch the icon in the properties dialog get the desired one and the icon in
the launcher get the icon with the same name of Bluecurve.
Wrong icon in launcher
Specified icon in launcher
I could see this with Mozilla, Xchat, even Galeon (which isn't part of RHL
anymore -- why do we ship an icon for it?).
I guess we need to not look up in the theme if it's an absolute path, or
something like that...
But we explicity kill the path when loading the icon to fix #106649. This is
very very ugly.
desktop file spec extension? there's no back compat extension here though.
maybe the custom icon chooser should only let you pick icons in the theme,
not arbitrary files...
To be frank, that'd be too much "we know what's good for you". The bug isn't
that I can choose an arbitrary icon file, it's that the panel doesn't use it.
If the bug isn't fixable we need to remove the unfixable functionality,
is all I'm saying.
I don't see a good fix due to the compat problem; the file format can be
extended, but not everyone reading the format will understand the extension.
Can you elaborate on why the bug isn't fixable? I looked at #100649 (which is
the bug George meant I guess), but I'm still not all that enlightened by reading
I don't understand the relationship to #100649 either, but
I assume there's some reason absolute paths currently get themed?
If not then it's fixable by not theming those.
I forgot to say gnome bugzilla #106649, not redhat bugzilla. I'm getting lost
in bugzili (is that the correct multiple for bugzillas)?
I don't think it's as bad as unfixable, at least for the panel since we can
extend the panel for the launchers since we're the only ones using those
desktops then. Unless of course someone dnds it somewhere else of course, then
the icon will change to however the drop location interprets the Icon= field.
Looking at gnome BZ #106649, I also think that using the basename of the icon
file is the right thing for DnD (as long as this is done consistently in all
places). In the properties dialog I'm not quite sure -- it could be one of:
- Always use the full path
- Use the full path only when using an icon not from the (current) theme
(potential for confusion when changing themes)
- Let the user choose whether to use "only theme icons" (no "Browse" button,
basename of the icon file) or not (shows Browse button, full path)
What do you think?
See what I comitted in gnome CVS, for a somewhat blurry description see