Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.1.hg74691fb6f837.fc21.src.rpm Description: Trivial sqlite3 binding for Go Fedora Account System Username: lsm5 Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6028690 Note: Pretty much the same as Bug 1009967, just that it didn't come with a license file included so I installed the BSD license by myself.
btw, docker 0.7-staging branch seems to use this package, that's why the review request
> Note: Pretty much the same as Bug 1009967, just that it didn't come with a > license file included so I installed the BSD license by myself. This is consistent. Russ Cox's (a core golang developer) comment refers to a LICENSE file that is not there. I'm guessing he's refering to the go compiler's LICENSE. // Copyright 2010 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file.
%changelog * Tue Oct 08 2013 Lokesh Mandvekar <lsm5> 0-0.2.hg74691fb6f837 - exclusivearch as per golang - debug_package nil Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.1.hg74691fb6f837.fc21.src.rpm
(In reply to Vincent Batts from comment #2) > This is consistent. Russ Cox's (a core golang developer) comment refers to a > LICENSE file that is not there. I'm guessing he's refering to the go > compiler's LICENSE. > > // Copyright 2010 The Go Authors. All rights reserved. > // Use of this source code is governed by a BSD-style > // license that can be found in the LICENSE file. Umm, did he comment somewhere?
%changelog * Tue Oct 08 2013 Lokesh Mandvekar <lsm5> 0-0.3.hg74691fb6f837 - golang license for 2012 installed Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.3.hg74691fb6f837.fc21.src.rpm
upstream request for license file http://code.google.com/p/gosqlite/issues/detail?id=21 (It's okay to add our own in the meantime.)
If you could add the following to the description (from the source code comments), This package has no exported API. It registers a driver for the standard Go database/sql package. I think that would be good. These really all should stay as noarch packages. The exclusivearch hack isn't a good solution to the PPC problem -- making the no-arch packages arch-specific is actually a worse issue, I think.
It's possible that adding "noarch" to the ExclusiveArch list will make that work -- I've seen a couple of suggestions for doing that. Seems kind of ugly but is the best I can think of right now.
(In reply to Lokesh Mandvekar from comment #4) > (In reply to Vincent Batts from comment #2) > > This is consistent. Russ Cox's (a core golang developer) comment refers to a > > LICENSE file that is not there. I'm guessing he's refering to the go > > compiler's LICENSE. > > > > // Copyright 2010 The Go Authors. All rights reserved. > > // Use of this source code is governed by a BSD-style > > // license that can be found in the LICENSE file. > > Umm, did he comment somewhere? This comment is from the *.go source code of this project. https://code.google.com/p/gosqlite/source/browse/sqlite/sqlite.go#1
%changelog * Tue Oct 08 2013 Lokesh Mandvekar <lsm5> 0-0.4.hg74691fb6f837 - description update - added noarch to exclusivearch list Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.3.hg74691fb6f837.fc21.src.rpm(In reply to Vincent Batts from comment #9) > (In reply to Lokesh Mandvekar from comment #4) > This comment is from the *.go source code of this project. > https://code.google.com/p/gosqlite/source/browse/sqlite/sqlite.go#1 silly me :|
%changelog * Tue Oct 08 2013 Lokesh Mandvekar <lsm5> 0-0.5.hg74691fb6f837 - buildarch: noarch Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.5.hg74691fb6f837.fc21.src.rpm
%changelog * Tue Oct 08 2013 Lokesh Mandvekar <lsm5> 0-0.6.hg74691fb6f837 - sql -> SQL, rpmlint warning fixed Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.5.hg74691fb6f837.fc21.src.rpm
Ignore Comment 12 (wrong srpm link) %changelog * Tue Oct 08 2013 Lokesh Mandvekar <lsm5> 0-0.6.hg74691fb6f837 - sql -> SQL, rpmlint warning fixed Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.6.hg74691fb6f837.fc21.src.rpm
also, koji looks good for dist-6E-epel http://koji.fedoraproject.org/koji/taskinfo?taskID=6036895 only rpmlint warning for spec and srpm: setup-not-quiet
I like not-quiet setup. :) Except for getting the exclusivearch/noarch quirk fixed, I think this is ready to go. See https://fedorahosted.org/fpc/ticket/355
As noted in IRC, the devel subpackage should have "Requires: sqlite-devel".
%changelog * Tue Oct 08 2013 Lokesh Mandvekar <lsm5> 0-0.7.hg74691fb6f837 - noarch for f19+ and rhel7+, exclusivearch otherwise - requires sqlite-devel Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc21.src.rpm
Review passed with same caveat as before: go lang guidelines are draft so we may need to update this to match as those are made official.
New Package SCM Request ======================= Package Name: golang-googlecode-sqlite Short Description: Trivial sqlite3 binding for Go Owners: lsm5 Branches: f19 f20 el6 InitialCC:
woops ... set the wrong fedora-cvs+ flag ...corrected to fedora-cvs?
Git done (by process-git-requests).
golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc20
golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc19
golang-googlecode-sqlite-0-0.7.hg74691fb6f837.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.7.hg74691fb6f837.el6
golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc20 has been pushed to the Fedora 20 testing repository.
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc20
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc19
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6
Package golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-11862/golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6 then log in and leave karma (feedback).
Package Change Request ====================== Package Name: golang-googlecode-sqlite InitialCC: golang-sig
Done.
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.