Bug 1015958 - Review Request: fst - run VST plugins under wine
Summary: Review Request: fst - run VST plugins under wine
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: FedoraAudio festige
TreeView+ depends on / blocked
Reported: 2013-10-07 06:41 UTC by Brendan Jones
Modified: 2014-01-24 07:49 UTC (History)
4 users (show)

Fixed In Version: lv2-triceratops-0.1.7-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-12-28 05:23:56 UTC
zbyszek: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Brendan Jones 2013-10-07 06:41:38 UTC
fst is a host to run VST audio plugins under wine. Supports 32bit GUI plugins only. 

SRPM: http://bsjones.fedorapeople.org/reviews/fst-1.8-0.1.20110131git20661444.fc20.src.rpm

SPEC: http://bsjones.fedorapeople.org/reviews/fst.spec

Comment 1 Christopher Meng 2013-10-07 08:36:47 UTC
Should use URL tag but not Url.

Comment 2 Ralf Corsepius 2013-10-07 09:00:47 UTC
(In reply to Christopher Meng from comment #1)
> Should use URL tag but not Url.
Not true - Both are equivalent. There is no technical reason to force packagers to using URL.

Comment 3 Christopher Meng 2013-10-07 09:02:36 UTC
(In reply to Ralf Corsepius from comment #2)
> (In reply to Christopher Meng from comment #1)
> > Should use URL tag but not Url.
> Not true - Both are equivalent. There is no technical reason to force
> packagers to using URL.

Then you should clean some reviewers who have told me this is wrong.

Comment 4 Zbigniew Jędrzejewski-Szmek 2013-10-25 00:50:55 UTC
1. Please use %{commit} for the sha1.

2. Please use http://repo.or.cz/w/%{name}.git/snapshot/%{commit}.tar.gz for Source0 and remove snapshot.sh.

3. Can you extend the %description a bit: for people who know very little about audio (like your reviewer :)), a hint what is VST would be helpful. Also, this package seems to be a library (because it has a -devel counterpart), but also a tool, since it is used to "run" things.

4. Use 'make CFLAGS=...' not 'CFLAGS=... make'.

5. Use 'make %{?_smp_mflags} ...', unless parallel build is not supported, in which case add a note.

6. Are those explicit permissions necessary? I'm pretty sure that plain 'mkdir -p' for dirs and 'cp -p' for files should work.

7. Doesn't build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6096872 ;(

Comment 5 Brendan Jones 2013-10-25 02:51:32 UTC
I've made all the changes you've suggested.

The headers are required for hosts to be able to query plugin contents, albeit without the requirement of the binary in the main package. 

Build failing because I can't pull in 32 bit packages into the 64 bit buildroot. Changed to exclusively i686.


SRPM: http://bsjones.fedorapeople.org/reviews/fst-1.9-0.1.20110131git20661444.fc20.src.rpm

SPEC: http://bsjones.fedorapeople.org/reviews/fst.spec

Comment 6 Zbigniew Jędrzejewski-Szmek 2013-10-25 04:08:01 UTC
1. Please also replace 20661444 in Release by %{commit}.

2. the comment about snapshot.sh is not needed

3. the description...

5. Use 'make %{?_smp_mflags} ...'...

6. Please add

Rpmlint says:

fst.i686: W: incoherent-version-in-changelog 1.8-0.2.20110131git20661444 ['1.9-0.1.20110131git20661444.fc20', '1.9-0.1.20110131git20661444']

Hm, I should test if this works... Not so easy. Will try tomorrow.

Comment 7 Zbigniew Jędrzejewski-Szmek 2013-10-26 00:07:07 UTC
OK, so it seems to launch correctly. Please fix the issues noted above.

Comment 9 Zbigniew Jędrzejewski-Szmek 2013-10-26 14:00:34 UTC
License OK, license file included.
Builds OK, even if only on i686.
Packaging is OK.
Latest version is packaged.

fst.i686: E: incorrect-fsf-address /usr/share/doc/fst/COPYING
fst.i686: W: no-manual-page-for-binary fst.exe
fst.src: W: file-size-mismatch 2066144.tar.gz = 36104, http://repo.or.cz/w/fst.git/snapshot/2066144.tar.gz = 0
Eh, the URL works.

fst-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/fst/jfst.c
fst-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/fst/audiomaster.c
fst-devel.i686: W: no-documentation
4 packages and 0 specfiles checked; 3 errors, 3 warnings.

Notify the upstream about outdated FSF address at your discretion.

Package is APPROVED.

Comment 10 Brendan Jones 2013-10-26 15:53:19 UTC
Thank you for the review!

New Package SCM Request
Package Name: fst
Short Description: Run VST audio plugins under Wine
Owners: bsjones
Branches: f18 f19 f20

Comment 11 Zbigniew Jędrzejewski-Szmek 2013-10-26 23:20:51 UTC

Comment 12 Gwyn Ciesla 2013-10-28 12:07:23 UTC
Git done (by process-git-requests).

Comment 13 Christopher Meng 2013-11-10 04:21:47 UTC

Comment 14 Christopher Meng 2013-12-28 05:23:56 UTC
Brendan, I closed this bug as RAWHIDE because I haven't see any builds for f20 or f19.


Comment 15 Fedora Update System 2013-12-28 18:00:08 UTC
lv2-triceratops-0.1.7-1.fc19 has been submitted as an update for Fedora 19.

Comment 16 Fedora Update System 2013-12-28 18:00:19 UTC
lv2-triceratops-0.1.7-1.fc20 has been submitted as an update for Fedora 20.

Comment 17 Fedora Update System 2014-01-24 07:49:35 UTC
lv2-triceratops-0.1.7-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.