Spec URL: http://goldmann.fedorapeople.org/package_review/hibernate-search/1/hibernate-search.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hibernate-search/1/hibernate-search-4.4.0-0.1.CR1.fc19.src.rpm Fedora Account System Username: goldmann Description: Full text search engines like Apache Lucene are very powerful technologies to add efficient free text search capabilities to applications. However, Lucene suffers several mismatches when dealing with object domain models. Amongst other things indexes have to be kept up to date and mismatches between index structure and domain model as well as query mismatches have to be avoided. Hibernate Search addresses these shortcomings - it indexes your domain model with the help of a few annotations, takes care of database/index synchronization and brings back regular managed objects from free text queries. Hibernate Search is using Apache Lucene under the cover.
Spec URL: http://goldmann.fedorapeople.org/package_review/hibernate-search/2/hibernate-search.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hibernate-search/2/hibernate-search-4.4.0-0.2.CR1.fc19.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=6070313 Changes: - Adjusted to use solr3 compat package
Contains some MP3-related code and MP3 file. This may need to be removed per [1]. Everything else looks OK. [1] https://fedoraproject.org/wiki/Forbidden_items#MP3_Support
Done. Spec URL: http://goldmann.fedorapeople.org/package_review/hibernate-search/3/hibernate-search.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hibernate-search/3/hibernate-search-4.4.0-0.3.CR1.fc19.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6074242 Changes: - Cleaned up source from mp3 (?!) files
I am taking this review.
The mp3 file is still there, mp3 test too: find -name *.mp3 grep -i -r mp3
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: If tests are skipped during package build explain why it was needed in a comment [x]: Pom files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [!]: Dist tag is present (not strictly required in GL). [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI Rpmlint ------- Checking: hibernate-search-4.4.0-0.3.CR1.fc21.noarch.rpm hibernate-search-javadoc-4.4.0-0.3.CR1.fc21.noarch.rpm hibernate-search-4.4.0-0.3.CR1.fc19.src.rpm hibernate-search.noarch: W: spelling-error %description -l en_US Amongst -> Among st, Among-st, Among hibernate-search.noarch: W: invalid-url URL: http://search.hibernate.org HTTP Error 403: Forbidden hibernate-search.noarch: E: incorrect-fsf-address /usr/share/doc/hibernate-search/lgpl.txt hibernate-search-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados hibernate-search-javadoc.noarch: W: invalid-url URL: http://search.hibernate.org HTTP Error 403: Forbidden hibernate-search-javadoc.noarch: E: incorrect-fsf-address /usr/share/doc/hibernate-search-javadoc/lgpl.txt hibernate-search.src: W: spelling-error %description -l en_US Amongst -> Among st, Among-st, Among hibernate-search.src: W: invalid-url URL: http://search.hibernate.org HTTP Error 403: Forbidden hibernate-search.src: W: invalid-url Source0: hibernate-search-4.4.0.CR1-CLEAN.tar.gz 3 packages and 0 specfiles checked; 2 errors, 7 warnings. Summary ------- 1) Dist tag should be %?dist, not %dist. Macro "dist" is not defined in some configurations. 2) From what I can see the license sould be LGPLv2+, not LGPLv2.
Fixed: Spec URL: http://goldmann.fedorapeople.org/package_review/hibernate-search/4/hibernate-search.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hibernate-search/4/hibernate-search-4.4.0-0.4.CR1.fc19.src.rpm
Approved.
Tested on koji, task id: 6074875
Thanks! New Package SCM Request ======================= Package Name: hibernate-search Short Description: Hibernate Search Owners: goldmann Branches: f20
Git done (by process-git-requests).
Thanks!