Red Hat Bugzilla – Bug 102071
rpmbuild should Require: gettext
Last modified: 2007-04-18 12:56:46 EDT
From Bugzilla Helper: User-Agent: Mozilla/5.0 Galeon/1.2.7 (X11; Linux i686; U;) Gecko/20030131 Description of problem: [anvil@gruyere ~]# rpmbuild --rebuild metacity-2.4.55-7.src.rpm [SNIP] + unset GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL + /bin/rm -f /var/tmp/metacity-root/usr/lib/libmetacity-private.la + /usr/lib/rpm/redhat/find-lang.sh /var/tmp/metacity-root metacity No translations found for metacity in /var/tmp/metacity-root erreur: Mauvais status de sortie pour /var/tmp/rpm-tmp.88952 (%install) Erreur de construction de RPM: Mauvais status de sortie pour /var/tmp/rpm-tmp.88952 (%install) zsh: exit 1 rpmbuild --rebuild metacity-2.4.55-7.src.rpm Please add 'BuildRequires:gettext' in spec file. Version-Release number of selected component (if applicable): metacity-2.4.55-7 How reproducible: Always Steps to Reproduce: 1. rpmbuild --rebuild metacity-2.4.55-7.src.rpm Additional info:
Makes more sense to me to have rpmbuild require gettext, if find-lang.sh requires it. Opinions?
I tend to agree (if you think you should do it for gettext, why not for glibc-devel, too? where does it stop?)
Moving to add Requires: gettext to rpmbuild.
*** Bug 102626 has been marked as a duplicate of this bug. ***
Both rpm-build and gettext are dependencies that are always supposed to be present, like make or gcc. Adding a build dependency to rpmbuild fixes nothing. Reopen and assign to distribution if you wish to argue.
Unfortunately Bugzilla won't let me reopen this, but I'd like to argue that for Fedora Core: 1) The list of "assumed present" packages must be published. 2) It's a packaging bug if a package doesn't build or the result doesn't work as expected because it doesn't list a build time dependency which is not in 1) or not pulled in by other deps. If gettext would for some reason not be in the list of assumed present packages, either adding "BuildRequires: gettext" into the dependent packages or "Requires: gettext" into rpm-build would satisfy the dep. The former would perhaps preferable because most packages build fine without gettext.
I agree with Ville and i re-open the bug :o) I must add that i saw some [fedora.us] packages (wxGTK, xine-lib..) rebuild running %find_lang without gettext being installed.
I'd rather drop find-lang.sh (there's redhat-rpm-config) than add Yet Another reuires for a script that is only occaisionally (majority of packages don't care about find-langs.sh). The tradeoff is between the benefit, find-lang.sh needs will be tracked through a rpm-build dependency, and cost, each and every user will be forced to install gettext. I believe the cost out weighs the benefit, and I would rather dump a rather trivial helper script than inflict another dependency on all rpm-build users. cpanflute has already been removed from rpm for this reason, the cost of maintaining a perl dependency outweighed whatever benefit there was in distributing a helper script.