Bug 1022588 - fedora-review: Do not install Java plugin
Summary: fedora-review: Do not install Java plugin
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-review
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Stanislav Ochotnicky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1021344
TreeView+ depends on / blocked
 
Reported: 2013-10-23 15:16 UTC by Mikolaj Izdebski
Modified: 2015-05-23 04:15 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-23 04:15:12 UTC
Type: Bug


Attachments (Terms of Use)
Proposed patch (1.28 KB, patch)
2013-10-23 15:23 UTC, Mikolaj Izdebski
no flags Details | Diff

Description Mikolaj Izdebski 2013-10-23 15:16:10 UTC
Description of problem:
Java plugin for Fedora Review is now available as part of Java Packages Tools project, which has become the primary maintainer of the plugin.

Please don't install Java plugin so that users can install it separately from Java Packages Tools.

Version-Release number of selected component (if applicable):
0.5.0-1

Comment 1 Mikolaj Izdebski 2013-10-23 15:23:58 UTC
Created attachment 815458 [details]
Proposed patch

Comment 2 Stanislav Ochotnicky 2013-10-23 16:08:47 UTC
That patch is actually not usable since f-r uses same specs for everything in el6+. I'll conditionalise this

Comment 3 Stanislav Ochotnicky 2013-10-24 08:59:23 UTC
Actually...in upstream we have a shim java plugin that warns about missing "fedora-review-plugin-java" when it's not installed. With next release this is going to be fixed and until then the warnings are actually not affecting the results at all.

After that the javapackges-tools will need to add subpackage for F18, F19 but that's about it

Comment 4 Orion Poplawski 2014-05-06 18:04:49 UTC
Still seeing the warning with 0.5.1-2.fc20

Comment 5 Alec Leamas 2015-04-15 18:36:43 UTC
See also upstream bug https://fedorahosted.org/FedoraReview/ticket/239

Comment 6 Alec Leamas 2015-05-23 04:15:12 UTC
Fixed since long. java-plugin is not installed by fedora-review, it only emits a warning about missing plugin for java code if plugin isn't installed. fedora-review-plugin-jave is maintained by the java SIG.

Closing


Note You need to log in before you can comment on or make changes to this bug.