Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-creole.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-creole-0.5.0-1.fc21.src.rpm Description: Creole is a lightweight markup language (http://wikicreole.org/). Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6147505
Taking. I would appreciate it if you would review one of my review requests. (e.g. bug 1031314 )
For 0.5.0-1 * Licensing - Currently I cannot find out where "and BSD" comes from. Reading README.creole, it seems that the license tag should be "Ruby". Would you check this? Other things seems okay. - spec file clean - Builds file - Can be installed - At least ruby -e "require 'creole' ; puts Creole::VERSION" works
(In reply to Mamoru TASAKA from comment #2) > For 0.5.0-1 > > * Licensing > - Currently I cannot find out where "and BSD" comes from. > Reading README.creole, it seems that the license tag should > be "Ruby". Would you check this? Thanks for reviewing. I thought "Ruby or BSD" was the correct summary to describe "the terms specified in the README file of the Ruby distribution"? Eg. https://github.com/ruby/ruby/blob/trunk/COPYING ... isn't that Ruby or BSD? Please correct me if not.
(In reply to Ken Dreyer from comment #3) > (In reply to Mamoru TASAKA from comment #2) > > For 0.5.0-1 > > > > * Licensing > > - Currently I cannot find out where "and BSD" comes from. > > Reading README.creole, it seems that the license tag should > > be "Ruby". Would you check this? > > Thanks for reviewing. I thought "Ruby or BSD" was the correct summary to > describe "the terms specified in the README file of the Ruby distribution"? > Eg. https://github.com/ruby/ruby/blob/trunk/COPYING ... isn't that Ruby or > BSD? Please correct me if not. Well, in that case I guess it should be "GPLv2 or Ruby", because Ruby's license changed from "GPLv2 or Ruby" to "BSD or Ruby" on ruby 1.9.3, and README.creole says Copyright (c) 2008. (I don't assume that creole upstream allows also-relicense when Ruby's license changes)
(In reply to Mamoru TASAKA from comment #4) > (I don't assume that creole upstream allows also-relicense when > Ruby's license changes) I meant "auto-relicense"
Thanks. I've adjusted the License field and included a copy of the GPLv2 text. * Tue Nov 19 2013 Ken Dreyer <ktdreyer> - 0.5.0-2 - Update License (RHBZ #1027521) - Change URL to use HTTPS Exact change in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-creole.git/commit/?id=0ed3c870578dea259bd5cd5b94acad261652d8b2 Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-creole.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-creole-0.5.0-2.fc21.src.rpm F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6198775
Please fix "install" command like bug 1028168 . ------------------------------------------------- This package (rubygem-creole) is APPROVED by mtasaka --------------------------------------------------
Thanks for pointing out the missing permissions on install. I'll fix that before importing. Thanks mtasaka for the review! New Package SCM Request ======================= Package Name: rubygem-creole Short Description: Lightweight markup language Owners: ktdreyer Branches: f19 f20
Git done (by process-git-requests).
rubygem-creole-0.5.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-creole-0.5.0-3.fc20
rubygem-creole-0.5.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-creole-0.5.0-3.fc19
rubygem-creole-0.5.0-3.fc19 has been pushed to the Fedora 19 testing repository.
rubygem-creole-0.5.0-3.fc19 has been pushed to the Fedora 19 stable repository.
rubygem-creole-0.5.0-3.fc20 has been pushed to the Fedora 20 stable repository.